From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] syscalls: ulimit01; Convert to the new library
Date: Fri, 6 Mar 2026 13:54:17 +0100 [thread overview]
Message-ID: <20260306125417.GA528953@pevik> (raw)
In-Reply-To: <20260304144424.10101-1-chrubis@suse.cz>
Hi Cyril,
> Linux does not implement UL_GMEMLIM, UL_GDESLIM and UL_GSHMEMLIM so we
> keep only the UL_GETFSIZE and UL_SETFSIZE.
...
LGTM, thanks for the cleanup.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
> +/*\
> + * Tests the basic functionality of ulimit() with UL_GETFSIZE and UL_SETFSIZE.
nit: Could you please change before merge ulimit() to
:manpage:`ulimit(3)`
so that we get link to https://man7.org/linux/man-pages/man3/ulimit.3.html ?
FYI kernel uses automarkup to recognise various things e.g. git hash [1].
Maybe we could employ it for git kernel commits.
But for man page it can have false positives [2].
[1] https://lore.kernel.org/linux-doc/87a4ydo1hf.fsf@trenco.lwn.net/
[2] https://lore.kernel.org/linux-doc/aWqg5XwPRXlzq4FI@devuan/
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-03-06 12:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 14:44 [LTP] [PATCH] syscalls: ulimit01; Convert to the new library Cyril Hrubis
2026-03-04 15:09 ` Andrea Cervesato via ltp
2026-03-06 12:54 ` Petr Vorel [this message]
2026-04-07 12:01 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260306125417.GA528953@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox