Re: [LTP] [PATCH v6] agents: Add AI agent configuration for code reviews

[Petr Vorel <pvorel@suse.cz>]

Hi Andrea,

thanks for your work. On a first look LGTM.

Acked-by: Petr Vorel <pvorel@suse.cz>

I wonder if we can somehow avoid duplicity with our Ground Rules
https://linux-test-project.readthedocs.io/en/latest/developers/ground_rules.html
Ideally text would be just in a single document.

...
> +### 6. Safe Macros
> +
> +- MUST use `SAFE_*` macros for system calls that must not fail
> +- Safe macros are defined in `include/` directory
Actually the signatures are defined there, the code mostly not, but that's minor
detail.

> +
> +### 7. Kernel Version Handling
> +
> +- MUST use `.min_kver` for kernel version gating
> +- MUST prefer runtime checks over compile-time checks
...

I guess I should send v2 for my patch and that could be updated here
https://patchwork.ozlabs.org/project/ltp/patch/20260128080121.18878-1-pvorel@suse.cz/
https://lore.kernel.org/ltp/20260128080121.18878-1-pvorel@suse.cz/

> +
> +### 13. Deprecated Features
> +
> +- MUST NOT define `[Description]` in the test description section

When we handle details like this, we may want to add rule to avoid unnecessary
tags e.g. .mount_device:

metadata/metaparse.c

static struct implies {
	const char *flag;
	const char **implies;
} implies[] = {
	{"mount_device", (const char *[]) {"format_device", "needs_device",
		"needs_tmpdir", NULL}},
	{"format_device", (const char *[]) {"needs_device", "needs_tmpdir",
		NULL}},
	{"all_filesystems", (const char *[]) {"needs_device", "needs_tmpdir",
		NULL}},
	{"needs_device", (const char *[]) {"needs_tmpdir", NULL}},
	{"needs_checkpoints", (const char *[]) {"needs_tmpdir", NULL}},
	{"resource_files", (const char *[]) {"needs_tmpdir", NULL}},
	{NULL, (const char *[]) {NULL}}
};

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp