[LTP] [PATCH] aio_cancel_4-1: Rewrite test

[LTP] [PATCH] aio_cancel_4-1: Rewrite test

[Martin Doucha]

The test schedules multiple async writes into a file and then hopes that
at least one will block long enough that it can be canceled
before completion. Use a socket pair instead of a file to force async
writes to block indefinitely and make sure at least one can be canceled.
Then cancel all requests on the input socket and check that request errors
and return values have been set correctly for the canceled requests.
This fixes a race condition where aio_cancel() could be delayed until
after all writes have already completed, making the test unreliable.

Signed-off-by: Martin Doucha <mdoucha@suse.cz>
---

Tested on kernels v4.4 and v6.12 as usual.

 .../conformance/interfaces/aio_cancel/4-1.c   | 136 +++++++-----------
 1 file changed, 49 insertions(+), 87 deletions(-)

diff --git a/testcases/open_posix_testsuite/conformance/interfaces/aio_cancel/4-1.c b/testcases/open_posix_testsuite/conformance/interfaces/aio_cancel/4-1.c
index ef615ae64..ac19d8b1a 100644
--- a/testcases/open_posix_testsuite/conformance/interfaces/aio_cancel/4-1.c
+++ b/testcases/open_posix_testsuite/conformance/interfaces/aio_cancel/4-1.c
@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2004, Bull SA. All rights reserved.
+ * Copyright (c) 2026 SUSE LLC
  * Created by:  Laurent.Vivier@bull.net
  * This file is licensed under the GPL license.  For the full content
  * of this license, see the COPYING file at the top level of this
@@ -14,122 +15,83 @@
  *
  * method:
  *
- *	we queue a lot of aio_write() operation to a file descriptor
- *	then we try to cancel all aio operation of this file descriptor
- *	we check with aio_error() state of each operation
- *	if aio_error() is ECANCELED and aio_return() is -1
- *	test is passed
- *	if aio_error() is ECANCELED and aio_return() is NOT -1
- *	test fails
- *	otherwise
- *	test is unresolved
+ *	open a pair of sockets and queue writes to them with aio_write()
+ *	execute aio_cancel() on the socket
+ *	check aio_error() and aio_return() results for writes which should
+ *	have been canceled
+ *	if any aio_error() is not ECANCELED or aio_return() is not -1,
+ *	the test fails
+ *	otherwise the test passes
  *
  */
 
-#include <stdio.h>
 #include <sys/types.h>
 #include <unistd.h>
-#include <sys/stat.h>
-#include <fcntl.h>
-#include <string.h>
-#include <errno.h>
-#include <stdlib.h>
-#include <aio.h>
 
 #include "posixtest.h"
-#include "tempfile.h"
+#include "aio_test.h"
 
 #define TNAME "aio_cancel/4-1.c"
 
-#define BUF_NB		128
-#define BUF_SIZE	(1024*1024)
+#define WRITE_COUNT	8
+#define MAX_COMPLETE	3
+
+static int fds[2];
+static struct aiocb aiocb[WRITE_COUNT];
 
 int main(void)
 {
-	char tmpfname[PATH_MAX];
-	int fd;
-	struct aiocb *aiocb[BUF_NB];
 	int i;
-	int in_progress;
 
 	if (sysconf(_SC_ASYNCHRONOUS_IO) < 200112L)
 		return PTS_UNSUPPORTED;
 
-	PTS_GET_TMP_FILENAME(tmpfname, "pts_aio_cancel_4_1");
-	unlink(tmpfname);
-	fd = open(tmpfname, O_CREAT | O_RDWR | O_EXCL, S_IRUSR | S_IWUSR);
-	if (fd == -1) {
-		printf(TNAME " Error at open(): %s\n", strerror(errno));
+	if (setup_aio(TNAME, fds, aiocb, WRITE_COUNT))
 		return PTS_UNRESOLVED;
-	}
-
-	unlink(tmpfname);
-
-	/* create AIO req */
-
-	for (i = 0; i < BUF_NB; i++) {
-		aiocb[i] = malloc(sizeof(struct aiocb));
-		if (aiocb[i] == NULL) {
-			printf(TNAME " Error at malloc(): %s\n",
-			       strerror(errno));
-			return PTS_UNRESOLVED;
-		}
-		memset(aiocb[i], 0, sizeof(struct aiocb));
-		aiocb[i]->aio_fildes = fd;
-		aiocb[i]->aio_buf = malloc(BUF_SIZE);
-		if (aiocb[i]->aio_buf == NULL) {
-			printf(TNAME " Error at malloc(): %s\n",
-			       strerror(errno));
-			return PTS_UNRESOLVED;
-		}
-		aiocb[i]->aio_nbytes = BUF_SIZE;
-		aiocb[i]->aio_offset = 0;
-		aiocb[i]->aio_sigevent.sigev_notify = SIGEV_NONE;
-	}
 
-	for (i = 0; i < BUF_NB; i++) {
-		if (aio_write(aiocb[i]) == -1) {
+	/* submit AIO req */
+	for (i = 0; i < WRITE_COUNT; i++) {
+		if (aio_write(&aiocb[i]) == -1) {
 			printf(TNAME " loop %d: Error at aio_write(): %s\n",
-			       i, strerror(errno));
+				i, strerror(errno));
+			cleanup_aio(fds, aiocb, WRITE_COUNT);
 			return PTS_FAIL;
 		}
 	}
 
-	/* try to cancel all
-	 * we hope to have enough time to cancel at least one
-	 */
-
-	if (aio_cancel(fd, NULL) == -1) {
+	/* cancel all */
+	if (aio_cancel(fds[0], NULL) == -1) {
 		printf(TNAME " Error at aio_cancel(): %s\n", strerror(errno));
+		cleanup_aio(fds, aiocb, WRITE_COUNT);
 		return PTS_FAIL;
 	}
 
-	close(fd);
-
-	do {
-		in_progress = 0;
-		for (i = 0; i < BUF_NB; i++) {
-			int ret;
-
-			ret = (aio_error(aiocb[i]));
-
-			if (ret == -1) {
-				printf(TNAME " Error at aio_error(): %s\n",
-				       strerror(errno));
-				return PTS_FAIL;
-			} else if (ret == EINPROGRESS)
-				in_progress = 1;
-			else if (ret == ECANCELED) {
-				if (aio_return(aiocb[i]) == -1) {
-					printf("Test PASSED\n");
-					return PTS_PASS;
-				}
-
-				printf(TNAME " aio_return is not -1\n");
-				return PTS_FAIL;
-			}
+	/* check results of requests that should have been canceled */
+	for (i = MAX_COMPLETE; i < WRITE_COUNT; i++) {
+		int ret = aio_error(&aiocb[i]);
+
+		if (ret == -1) {
+			printf(TNAME " Error at aio_error(): %s\n",
+			       strerror(errno));
+			cleanup_aio(fds, aiocb, WRITE_COUNT);
+			return PTS_FAIL;
+		} else if (ret != ECANCELED) {
+			printf(TNAME " Bad task #%d result: %s "
+				"(expected ECANCELED)\n", i, strerror(ret));
+			cleanup_aio(fds, aiocb, WRITE_COUNT);
+			return PTS_FAIL;
+		}
+
+		ret = aio_return(&aiocb[i]);
+
+		if (ret != -1) {
+			printf(TNAME " aio_return(): %d (expected -1)\n", ret);
+			cleanup_aio(fds, aiocb, WRITE_COUNT);
+			return PTS_FAIL;
 		}
-	} while (in_progress);
+	}
 
-	return PTS_UNRESOLVED;
+	cleanup_aio(fds, aiocb, WRITE_COUNT);
+	printf("Test PASSED\n");
+	return PTS_PASS;
 }
-- 
2.52.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] aio_cancel_4-1: Rewrite test

[Andrea Cervesato via ltp]

LGTM
Reviewed-by: Andrea Cervesato <andrea.cervesato@suse.com>

--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] aio_cancel_4-1: Rewrite test

[Petr Vorel]

Hi Martin, Andrea,

thanks, merged!

I guess we still have 1-1.c and 8-1.c to rewrite.
1-1.c and 10-1.c aren't racy, right?

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] aio_cancel_4-1: Rewrite test

[Martin Doucha]

On 3/16/26 11:50, Petr Vorel wrote:
> Hi Martin, Andrea,
> 
> thanks, merged!
> 
> I guess we still have 1-1.c and 8-1.c to rewrite.
> 1-1.c and 10-1.c aren't racy, right?

Hi,
aio_cancel/6-1.c still needs a rewrite, the other aio_cancel() tests 
don't have any race issues. Then I'll continue with aio_suspend() tests 
which have the same race conditions.

-- 
Martin Doucha   mdoucha@suse.cz
SW Quality Engineer
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] aio_cancel_4-1: Rewrite test

[Petr Vorel]

> On 3/16/26 11:50, Petr Vorel wrote:
> > Hi Martin, Andrea,

> > thanks, merged!

> > I guess we still have 1-1.c and 8-1.c to rewrite.
> > 1-1.c and 10-1.c aren't racy, right?

> Hi,
> aio_cancel/6-1.c still needs a rewrite, the other aio_cancel() tests don't
> have any race issues. Then I'll continue with aio_suspend() tests which have
> the same race conditions.

Thank you for info and for the work itself!

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp