[LTP] [PATCH] cve: icmp_rate_limit: Make sure icmp_msgs_burst = 50

[LTP] [PATCH] cve: icmp_rate_limit: Make sure icmp_msgs_burst = 50

[Cyril Hrubis]

The test is written with an assumption that the burst for icmp message
is 50 since it sends 100 messages in a batch and expects the kernel to
go over the limit. The easiest way how to fix the test is to set the
sysctl to 50 before the test and restore it later.

Suggested-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
---
 testcases/cve/icmp_rate_limit01.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/testcases/cve/icmp_rate_limit01.c b/testcases/cve/icmp_rate_limit01.c
index 0305ad095..78480cea6 100644
--- a/testcases/cve/icmp_rate_limit01.c
+++ b/testcases/cve/icmp_rate_limit01.c
@@ -255,6 +255,7 @@ static struct tst_test test = {
 	},
 	.save_restore = (const struct tst_path_val[]) {
 		{"/proc/sys/user/max_user_namespaces", "1024", TST_SR_SKIP},
+		{"/proc/sys/net/ipv4/icmp_msgs_burst", "50", TST_SR_TBROK},
 		{}
 	},
 	.tags = (const struct tst_tag[]) {
-- 
2.52.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] cve: icmp_rate_limit: Make sure icmp_msgs_burst = 50

[Martin Doucha]

Hi,
yes, that's the best fix. Thank you.

Reviewed-by: Martin Doucha <mdoucha@suse.cz>

On 3/12/26 11:43, Cyril Hrubis wrote:
> The test is written with an assumption that the burst for icmp message
> is 50 since it sends 100 messages in a batch and expects the kernel to
> go over the limit. The easiest way how to fix the test is to set the
> sysctl to 50 before the test and restore it later.
> 
> Suggested-by: Eric Dumazet <edumazet@google.com>
> Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
> ---
>   testcases/cve/icmp_rate_limit01.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/testcases/cve/icmp_rate_limit01.c b/testcases/cve/icmp_rate_limit01.c
> index 0305ad095..78480cea6 100644
> --- a/testcases/cve/icmp_rate_limit01.c
> +++ b/testcases/cve/icmp_rate_limit01.c
> @@ -255,6 +255,7 @@ static struct tst_test test = {
>   	},
>   	.save_restore = (const struct tst_path_val[]) {
>   		{"/proc/sys/user/max_user_namespaces", "1024", TST_SR_SKIP},
> +		{"/proc/sys/net/ipv4/icmp_msgs_burst", "50", TST_SR_TBROK},
>   		{}
>   	},
>   	.tags = (const struct tst_tag[]) {


-- 
Martin Doucha   mdoucha@suse.cz
SW Quality Engineer
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] cve: icmp_rate_limit: Make sure icmp_msgs_burst = 50

[Petr Vorel]

Hi Cyril, Martin,

> Hi,
> yes, that's the best fix. Thank you.

Also LGTM.
Merged.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp