[LTP] [PATCH] tst_kconfig: Don't consider CONFIG_FAULT_INJECTION slow

[LTP] [PATCH] tst_kconfig: Don't consider CONFIG_FAULT_INJECTION slow

[Petr Vorel]

Tumbleweed has only CONFIG_FAULT_INJECTION. All tests run ok before
(without 4x longer expected runtime), let's don't blindly increase it.

Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
IMHO the only effect of the detection on Tumbleweed would be if test
gets stuck will block testing for 2 min instead of just 30 sec.

Kind regards,
Petr

 lib/tst_kconfig.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/tst_kconfig.c b/lib/tst_kconfig.c
index adc56503e2..5f778d2adc 100644
--- a/lib/tst_kconfig.c
+++ b/lib/tst_kconfig.c
@@ -647,7 +647,6 @@ static struct tst_kconfig_var slow_kconfigs[] = {
 	TST_KCONFIG_INIT("CONFIG_DEBUG_NET"),
 	TST_KCONFIG_INIT("CONFIG_EXT4_DEBUG"),
 	TST_KCONFIG_INIT("CONFIG_QUOTA_DEBUG"),
-	TST_KCONFIG_INIT("CONFIG_FAULT_INJECTION"),
 	TST_KCONFIG_INIT("CONFIG_DEBUG_OBJECTS")
 };
 
-- 
2.51.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] tst_kconfig: Don't consider CONFIG_FAULT_INJECTION slow

[Andrea Cervesato via ltp]

Hi Petr,

I didn't use fault injection extensively, but I read that when verbose mode is
enabled we might have a big slowdown, so I wouldn't skip this check.

Eventually, we can implement a check that verifies if fault injection is enabled
with a high verbosity. That would probably make more sense.

Regards,
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] tst_kconfig: Don't consider CONFIG_FAULT_INJECTION slow

[Petr Vorel]

Hi Andrea,

> Hi Petr,

> I didn't use fault injection extensively, but I read that when verbose mode is
> enabled we might have a big slowdown, so I wouldn't skip this check.

But it's default off. If one enables it, it could also increase LTP_RUNTIME_MUL.
IMHO the only effect now is 4* longer timeout on a kernel bug which freezes test
running.

> Eventually, we can implement a check that verifies if fault injection is enabled
> with a high verbosity. That would probably make more sense.

Do you mean to look if /sys/kernel/debug/fail*/verbose exist and contain 2?

https://origin.kernel.org/doc/html/latest/fault-injection/fault-injection.html#configure-fault-injection-capabilities-behavior

Kind regards,
Petr

> Regards,

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp