From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 84FA7E9A779 for ; Tue, 24 Mar 2026 12:50:40 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id D9FC53E4B83 for ; Tue, 24 Mar 2026 13:50:38 +0100 (CET) Received: from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [IPv6:2001:4b78:1:20::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 829EB3DDAD6 for ; Tue, 24 Mar 2026 13:50:20 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-3.smtp.seeweb.it (Postfix) with ESMTPS id 227E71A01069 for ; Tue, 24 Mar 2026 13:50:18 +0100 (CET) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 7FA655BF21; Tue, 24 Mar 2026 12:50:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1774356612; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=par3rlGEJNGggp6akuY+08bbk+QtLwhIL38bAYY1v10=; b=EAQok9lU6o6Atbnj0Q8bpsaaFKGxpE1efWqLgcVXFzfQLJEGlEbqBF8JzAVZi9scJariNA 5ymU9WYnPKZmq1X97x+dYz/WW3M7LwexTGeMsUUpU7DYaw1DENgrJnj7bHD12Ae5mNRYez HjBTrn6Vv/1H7BCCuU2+gkvSwllKsYo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1774356612; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=par3rlGEJNGggp6akuY+08bbk+QtLwhIL38bAYY1v10=; b=XpH+KFj6e9ThzZBSglOAejL5syhvYqNObhUtqeEr4VsLKOIvUWet9RaSI2Lo7yn5ZHXEi4 ELqdEMsi3ITk4FAQ== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=EAQok9lU; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=XpH+KFj6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1774356612; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=par3rlGEJNGggp6akuY+08bbk+QtLwhIL38bAYY1v10=; b=EAQok9lU6o6Atbnj0Q8bpsaaFKGxpE1efWqLgcVXFzfQLJEGlEbqBF8JzAVZi9scJariNA 5ymU9WYnPKZmq1X97x+dYz/WW3M7LwexTGeMsUUpU7DYaw1DENgrJnj7bHD12Ae5mNRYez HjBTrn6Vv/1H7BCCuU2+gkvSwllKsYo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1774356612; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=par3rlGEJNGggp6akuY+08bbk+QtLwhIL38bAYY1v10=; b=XpH+KFj6e9ThzZBSglOAejL5syhvYqNObhUtqeEr4VsLKOIvUWet9RaSI2Lo7yn5ZHXEi4 ELqdEMsi3ITk4FAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5A18843E47; Tue, 24 Mar 2026 12:50:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id YT30FISIwmkoAgAAD6G6ig (envelope-from ); Tue, 24 Mar 2026 12:50:12 +0000 Date: Tue, 24 Mar 2026 13:50:02 +0100 From: Petr Vorel To: Wei Gao , ltp@lists.linux.it Message-ID: <20260324125002.GA71154@pevik> References: <20250526143551.1321709-1-wegao@suse.com> <20250603214503.3792293-1-wegao@suse.com> <20260316084920.GA291437@pevik> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260316084920.GA291437@pevik> X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-3.71 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_RHS_NOT_FQDN(0.50)[]; HAS_REPLYTO(0.30)[pvorel@suse.cz]; R_DKIM_ALLOW(-0.20)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; FUZZY_RATELIMITED(0.00)[rspamd.com]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.cz:dkim,suse.cz:replyto]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; MISSING_XM_UA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; DKIM_TRACE(0.00)[suse.cz:+]; RCPT_COUNT_THREE(0.00)[3]; REPLYTO_EQ_FROM(0.00)[] X-Rspamd-Queue-Id: 7FA655BF21 X-Virus-Scanned: clamav-milter 1.0.9 at in-3.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v3] fsconfig04.c: Check FSCONFIG_SET_PATH X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi Wei, > + tune2fs = popen(path, "r"); Could you please use SAFE_POPEN() ? Maybe if you don't get any feedback could you please send v4 - rebased v3 with the changes below? Kind regards, Petr > +++ testcases/kernel/syscalls/fsconfig/fsconfig04.c > @@ -24,7 +24,7 @@ > #include "tst_test.h" > #include "lapi/fsmount.h" > -#include "old/old_device.h" > +#include "old/tso_device.h" > #define MNTPOINT "mntpoint" > #define LOOP_DEV_SIZE 10 > @@ -150,9 +150,9 @@ static struct tst_test test = { > .needs_root = 1, > .format_device = 1, > .mntpoint = MNTPOINT, > - .needs_cmds = (const char *[]) { > - "tune2fs", > - NULL > + .needs_cmds = (struct tst_cmd[]) { > + {.cmd = "tune2fs"}, > + {} > }, > .filesystems = (struct tst_fs []) { > {.type = "ext3"}, -- Mailing list info: https://lists.linux.it/listinfo/ltp