public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Martin Cermak <mcermak@redhat.com>
Cc: valgrind-developers@lists.sourceforge.net, ltp@lists.linux.it
Subject: Re: [LTP] [Valgrind-developers] [RFC PATCH 1/1] LTP tests: Run without LTP_REPRODUCIBLE_OUTPUT=1
Date: Wed, 25 Mar 2026 10:10:03 +0100	[thread overview]
Message-ID: <20260325091003.GA86256@pevik> (raw)
In-Reply-To: <20260325090648.diugdugszgd3inuo@lida.tpb.lab.eng.brq.redhat.com>

> On  Tue  2026-03-24  15:09 , Martin Cermak wrote:
> > On  Tue  2026-03-24  14:18 , Cyril Hrubis wrote:
> > > Hi!
> > > > LTP_REPRODUCIBLE_OUTPUT=1 environment variable was added in 5894abc5f to
> > > > help valgrind to use LTP for testing. It discards the actual content of
> > > > the messages printed by the test (removes everything after printing
> > > > TINFO/TPASS/TFAIL/...  flag).

> > > > Later LTP_QUIET=1 was added which suppresses printing TCONF, TWARN,
> > > > TINFO, and TDEBUG messages. Therefore LTP_REPRODUCIBLE_OUTPUT=1 is not
> > > > needed any more.

> > > I do not think so. We still have things like pids and timestamps in
> > > TPASS/TFAIL messages that needs to be removed in order for the output to
> > > be reproducible.

> > From Valgrind persp, seems like we could drop it at the first
> > glance.  But let me confirm that based on a thorough check.

> My quick guess above was wrong.  We do need
> LTP_REPRODUCIBLE_OUTPUT for Valgrind testing.
> Please keep it.

Thanks for info, Martin. Sure, please drop this patch.

I still feel these 2 variables somehow overlap, wouldn't it make sense to merge
the functionality into a single variable?

Kind regards,
Petr

> Thank-you,
> Martin



-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2026-03-25  9:10 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-23 21:08 [LTP] [RFC PATCH 1/1] LTP tests: Run without LTP_REPRODUCIBLE_OUTPUT=1 Petr Vorel
2026-03-24 13:18 ` Cyril Hrubis
2026-03-24 14:09   ` [LTP] [Valgrind-developers] " Martin Cermak via ltp
2026-03-25  9:06     ` Martin Cermak via ltp
2026-03-25  9:10       ` Petr Vorel [this message]
2026-03-25  9:21         ` Martin Cermak via ltp
2026-03-25  9:37           ` Cyril Hrubis
2026-03-25  9:42             ` Martin Cermak via ltp
2026-03-25  9:57               ` Cyril Hrubis
2026-03-25 10:01                 ` Martin Cermak via ltp
2026-03-25 13:57                 ` Petr Vorel
2026-03-25 14:52                   ` Martin Cermak via ltp
2026-03-26 16:42                     ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260325091003.GA86256@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=mcermak@redhat.com \
    --cc=valgrind-developers@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox