From: Petr Vorel <pvorel@suse.cz>
To: Ricardo Branco <rbranco@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2] userfaultfd: Minor fixes
Date: Thu, 26 Mar 2026 13:32:55 +0100 [thread overview]
Message-ID: <20260326123255.GB152048@pevik> (raw)
In-Reply-To: <33458536-f2e1-4ab8-a7b7-5882481dfa9b@suse.de>
> On 3/26/26 9:38 AM, Andrea Cervesato wrote:
> > Hi ricardo,
> > > + if (page) {
> > > + SAFE_MUNMAP(page, page_size);
> > > + SAFE_MUNMAP(copy_page, page_size);
> > > + page = NULL;
> > > + }
> > This is gonna TBROK when copy_page is NULL. The same apply to all other
> > tests which are affected by the same bug.
> Fixed in v3.
> BTW, we have a minor difference in tests:
> $ diff userfaultfd03.c userfaultfd06.c
> < tst_brk(TBROK | TERRNO, "Received unexpected UFFD_EVENT %d",
> msg.event);
> ---
> > tst_brk(TFAIL, "Received unexpected UFFD_EVENT %d", msg.event);
> I think we should have TFAIL, WDYT?
Yes, IMHO TFAIL.
Regards other cleanup: I again double checked if some test could be merged with
others but haven't found any.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-03-26 12:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 15:47 [LTP] [PATCH v2] userfaultfd: Minor fixes Ricardo Branco
2026-03-26 8:38 ` Andrea Cervesato via ltp
2026-03-26 11:37 ` Ricardo Branco
2026-03-26 12:32 ` Petr Vorel [this message]
2026-03-26 12:43 ` Andrea Cervesato via ltp
2026-03-26 13:12 ` Petr Vorel
2026-03-26 12:38 ` Andrea Cervesato via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260326123255.GB152048@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=rbranco@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox