Re: [LTP] [PATCH v2 1/1] editorconfig: add consistent formatting rules for LTP

[Petr Vorel <pvorel@suse.cz>]

> Hi Jan,

> > # C/Assembly source files, headers, and shell files use tabs
> > [{*.{c,h,S,sh},ver_linux}]
> > indent_style = tab
> > indent_size = 4

> LTP follows Linux kernel coding style, which uses 8-character-wide tabs.
> This should be indent_size = 8.

FYI I asked for 4 in v1 [1], Jan had originally 8 and I'm ok with following
kernel. It's just my personal preference to display tab as 4 spaces and not 8
(IMHO editorconfig plugins don't allow certain setup to be overwritten).

Kind regards,
Petr

[1] https://lore.kernel.org/ltp/20260310132227.GC39882@pevik/

> > # Python and Perl: default to tabs (most test files use tabs, checkpatch.pl which we modify)
> > [*.{py,pl}]
> > indent_style = tab
> > indent_size = 8

> Not 100% sure about this.

> The Python test files in the tree (e.g. pm_sched_domain.py, pm_ilb_test.py)
> all use 4-space indentation, not tabs. The default for *.py should be
> indent_style = space / indent_size = 4. Perl (checkpatch.pl) does use tabs,
> so it should get its own section.

> Also kirk uses 4 tabs indentation. So I guess we need to invert the two rules
> at this point.

> Regards,

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp