Re: [LTP] [PATCH v3] userfaultfd: Minor fixes

[Petr Vorel <pvorel@suse.cz>]

Hi all,

> - Use POSIX semantics for thread function
> - Set cleanup to call reset_pages

LGTM.

As a separate effort: Cyril raised a question if (as a separate effort) should
all test have some kconfig check (e.g. CONFIG_USERFAULTFD=y)

IMHO it's a question if we are ok with wide spread of needs_kconfig even if it's
not necessary (i.e. here SAFE_USERFAULTFD() check. In that case the benefit
would be 1) documentation of dependencies for testers in the test catalog 2)
check earlier that before running test code. And of course disadvantage to
really drag kconfig dependency, but we have accepted that already.

Ideally we'd decide on some policy (which may also includes .needs_drivers).
@all I planned to reword my original policy patch [1] to Li's suggestion +
Cyril's kconfig changes [2], but that still does not have "use kconfig to
document dependencies".

Kind regards,
Petr

[1] https://patchwork.ozlabs.org/project/ltp/patch/20260128080121.18878-1-pvorel@suse.cz/
[2] https://patchwork.ozlabs.org/comment/3662031/

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp