From: Petr Vorel <pvorel@suse.cz>
To: Ricardo Branco <rbranco@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2] userfaultfd: Add new test using UFFDIO_CONTINUE
Date: Wed, 1 Apr 2026 08:01:49 +0200 [thread overview]
Message-ID: <20260401060149.GA121545@pevik> (raw)
In-Reply-To: <e24009c4-8563-4f3f-9ad2-a05c5c35e861@suse.de>
Hi Ricardo,
> On 3/31/26 12:18 PM, Petr Vorel wrote:
> > Maybe SAFE_SYSCONF(_SC_PAGE_SIZE) or because it should be safe:
> > getpagesize();
> Opted for SAFE_SYSCONF as getpagesize() returns int.
+1
> > > + }
> > > +
> > > + if (uffd != -1) {
> > > + SAFE_CLOSE(uffd);
> > > + uffd = -1;
> > And here.
> Andrea pointed me to this LLM suggestion that got it wrong:
> https://github.com/acerv/ltp-agent/actions/runs/23788068990
> It's a cool thing that we're reviewing code that I used as template
> to fix the userfaultfd tests in the other PR with fixes.
Yeah, I already asked him yesterday to teach agent to have look into includes as
well :).
Kind regards,
Petr
> Best,
> Ricardo.
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2026-04-01 6:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 18:57 [LTP] [PATCH v2] userfaultfd: Add new test using UFFDIO_CONTINUE Ricardo Branco
2026-03-31 10:18 ` Petr Vorel
2026-03-31 22:09 ` Ricardo Branco
2026-04-01 6:01 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260401060149.GA121545@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=rbranco@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox