Re: [LTP] [PATCH 17/17] doc: metadata: Remove needs_drivers from docs

[Petr Vorel <pvorel@suse.cz>]

> Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
> ---
>  doc/developers/writing_tests.rst |  3 ---
>  doc/old/C-Test-API.asciidoc      | 13 ++++++-------
>  metadata/README.md               | 15 ++++++---------
>  3 files changed, 12 insertions(+), 19 deletions(-)

> diff --git a/doc/developers/writing_tests.rst b/doc/developers/writing_tests.rst
> index 992374f8b..5b1516ba5 100644
> --- a/doc/developers/writing_tests.rst
> +++ b/doc/developers/writing_tests.rst
> @@ -435,9 +435,6 @@ LTP C And Shell Test API Comparison
>      * - .needs_device
>        - TST_NEEDS_DEVICE

> -    * - .needs_drivers
> -      - TST_NEEDS_DRIVERS
> -
NOTE: this is the old comparison for tst_test.sh, it should be change:

 -    * - not applicable
 -      - TST_NEEDS_DRIVERS

>      * - .needs_kconfigs
>        - TST_NEEDS_KCONFIGS

> diff --git a/doc/old/C-Test-API.asciidoc b/doc/old/C-Test-API.asciidoc
> index 72fd2731d..7493fc578 100644
> --- a/doc/old/C-Test-API.asciidoc
> +++ b/doc/old/C-Test-API.asciidoc
> @@ -1621,13 +1621,12 @@ test should include 'tst_checksum.h' header, then can call 'tst_crc32c()'.
>  1.26 Checking kernel for the driver support
>  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

> -Some tests may need specific kernel drivers, either compiled in, or built
> -as a module. If '.needs_drivers' points to a 'NULL' terminated array of kernel
> -module names these are all checked and the test exits with 'TCONF' on the
> -first missing driver.
> -
> -The detection is based on reading 'modules.dep' and 'modules.builtin' files
> -generated by kmod. The check is skipped on Android.
> +Some tests may need specific kernel drivers, either compiled in, or built as a
> +module. For this cases a mappping of kernel config options to modules is
> +maintained in the kconfig checker. When a kernel config option is requested by
Please amend before merge to use formatting:
``modules.dep``

> +a test that has associated mapping in the kconfig source the 'modules.dep' file
> +is checked for module presence when the option is set to 'm'. The check is
... set to ``m``.
> +skipped on Android.

The rest LGTM.
Reviewed-by: Petr Vorel <pvorel@suse.cz>

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp