public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 03/17] lib: tst_kernel: Add tst_check_module_driver()
Date: Thu, 2 Apr 2026 23:47:27 +0200	[thread overview]
Message-ID: <20260402214727.GE225068@pevik> (raw)
In-Reply-To: <20260402121356.31266-4-chrubis@suse.cz>

Hi Cyril,

> @@ -200,16 +200,18 @@ static int tst_search_driver(const char *driver, const char *file)

>  int tst_check_builtin_driver(const char *driver)
>  {
> -	if (!tst_search_driver(driver, "modules.builtin"))
> -		return 0;
> +	return tst_search_driver(driver, "modules.builtin");
> +}

> -	return -1;
> +int tst_check_module_driver(const char *driver)
> +{
> +	return tst_search_driver(driver, "modules.dep");

Thinking about it twice, could we check for the module by reading
/sys/module/? Our current approach shows what module *should* be available, but
that might not be true for some reason (i.e. loadable module not installed).

Unfortunately while this works for loadable modules (and IMHO worth to add it),
builtin modules are here only if they have a version or at least one parameter
[1].  And this will not work at least for hwpoison_inject.

Kind regards,
Petr

[1] https://www.kernel.org/doc/Documentation/ABI/stable/sysfs-module

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  parent reply	other threads:[~2026-04-02 21:47 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-02 12:13 [LTP] [PATCH 00/17] Replace needs_drivers with needs_kconfigs Cyril Hrubis
2026-04-02 12:13 ` [LTP] [PATCH 01/17] syscalls: ioctl08: Remove .needs_drivers Cyril Hrubis
2026-04-02 21:34   ` Petr Vorel
2026-04-02 12:13 ` [LTP] [PATCH 02/17] lib: shell: Remove needs_drivers from JSON parser Cyril Hrubis
2026-04-02 21:29   ` Petr Vorel
2026-04-02 12:13 ` [LTP] [PATCH 03/17] lib: tst_kernel: Add tst_check_module_driver() Cyril Hrubis
2026-04-02 21:26   ` Petr Vorel
2026-04-02 21:47   ` Petr Vorel [this message]
2026-04-07  9:43     ` Cyril Hrubis
2026-04-07 11:15       ` Petr Vorel
2026-04-07 11:24         ` Cyril Hrubis
2026-04-08  7:06           ` Petr Vorel
2026-04-02 12:13 ` [LTP] [PATCH 04/17] lib: tst_kconfig: Add module presence checks Cyril Hrubis
2026-04-03  3:09   ` Li Wang via ltp
2026-04-07 10:05     ` Cyril Hrubis
2026-04-07 11:40       ` Li Wang via ltp
2026-04-07 11:44         ` Cyril Hrubis
2026-04-02 12:13 ` [LTP] [PATCH 05/17] tests: kvm: Switch from needs_drivers to needs_kconfigs Cyril Hrubis
2026-04-02 12:13 ` [LTP] [PATCH 06/17] tests: zram03: " Cyril Hrubis
2026-04-02 12:13 ` [LTP] [PATCH 07/17] tests: squashfs01: " Cyril Hrubis
2026-04-02 12:13 ` [LTP] [PATCH 08/17] tests: ioctl: " Cyril Hrubis
2026-04-02 12:13 ` [LTP] [PATCH 09/17] tests: madvise11: " Cyril Hrubis
2026-04-02 12:13 ` [LTP] [PATCH 10/17] tests: quotactl: " Cyril Hrubis
2026-04-02 12:13 ` [LTP] [PATCH 11/17] tests: uevent: " Cyril Hrubis
2026-04-02 12:13 ` [LTP] [PATCH 12/17] cve: tcindex01: " Cyril Hrubis
2026-04-02 12:13 ` [LTP] [PATCH 13/17] tests: can: " Cyril Hrubis
2026-04-02 12:13 ` [LTP] [PATCH 14/17] tests: fsetxattr: " Cyril Hrubis
2026-04-02 12:13 ` [LTP] [PATCH 15/17] sctp: " Cyril Hrubis
2026-04-02 12:13 ` [LTP] [PATCH 16/17] lib: tst_test: Remove now unused needs_drivers Cyril Hrubis
2026-04-03  3:01   ` Li Wang via ltp
2026-04-07 10:02     ` Cyril Hrubis
2026-04-07 11:39       ` Li Wang via ltp
2026-04-07 11:40         ` Cyril Hrubis
2026-04-02 12:13 ` [LTP] [PATCH 17/17] doc: metadata: Remove needs_drivers from docs Cyril Hrubis
2026-04-02 21:34   ` Petr Vorel
2026-04-02 21:59 ` [LTP] [PATCH 00/17] Replace needs_drivers with needs_kconfigs Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260402214727.GE225068@pevik \
    --to=pvorel@suse.cz \
    --cc=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox