[LTP] [PATCH] proc01: whitelist biba attr files returning EINVAL

[LTP] [PATCH] proc01: whitelist biba attr files returning EINVAL

[Ming Wang]

proc01 already treats several attr files under /proc/self/attr and
/proc/self/task/*/attr as known exceptions that may return EINVAL
on read.

On systems exposing biba attr files, reads from
/proc/self/attr/biba/* and /proc/self/task/*/attr/biba/* also
return EINVAL, which makes proc01 report false failures.

Add both path patterns to known_issues[] so the testcase keeps
reporting real regressions while ignoring this expected behavior.

Signed-off-by: Ming Wang <wangming01@loongson.cn>
---
 testcases/kernel/fs/proc/proc01.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/testcases/kernel/fs/proc/proc01.c b/testcases/kernel/fs/proc/proc01.c
index c90e509a3243..dadfb240fd24 100644
--- a/testcases/kernel/fs/proc/proc01.c
+++ b/testcases/kernel/fs/proc/proc01.c
@@ -100,7 +100,9 @@ static const struct mapping known_issues[] = {
 	{"read", "/proc/self/attr/selinux/*", EINVAL},
 	{"read", "/proc/self/attr/smack/*", EINVAL},
 	{"read", "/proc/self/attr/apparmor/*", EINVAL},
+	{"read", "/proc/self/attr/biba/*", EINVAL},
 	{"read", "/proc/self/task/[0-9]*/attr/*", EINVAL},
+	{"read", "/proc/self/task/[0-9]*/attr/biba/*", EINVAL},
 	{"read", "/proc/self/task/[0-9]*/attr/smack/*", EINVAL},
 	{"read", "/proc/self/task/[0-9]*/attr/selinux/*", EINVAL},
 	{"read", "/proc/self/task/[0-9]*/attr/apparmor/*", EINVAL},
-- 
2.43.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

[LTP] [PATCH] proc01: whitelist biba attr files returning EINVAL

[Ming Wang]

proc01 already treats several attr files under /proc/self/attr and
/proc/self/task/*/attr as known exceptions that may return EINVAL
on read.

On systems exposing biba attr files, reads from
/proc/self/attr/biba/* and /proc/self/task/*/attr/biba/* also
return EINVAL, which makes proc01 report false failures.

Add both path patterns to known_issues[] so the testcase keeps
reporting real regressions while ignoring this expected behavior.

Signed-off-by: Ming Wang <wangming01@loongson.cn>
---
 testcases/kernel/fs/proc/proc01.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/testcases/kernel/fs/proc/proc01.c b/testcases/kernel/fs/proc/proc01.c
index c90e509a3243..dadfb240fd24 100644
--- a/testcases/kernel/fs/proc/proc01.c
+++ b/testcases/kernel/fs/proc/proc01.c
@@ -100,7 +100,9 @@ static const struct mapping known_issues[] = {
 	{"read", "/proc/self/attr/selinux/*", EINVAL},
 	{"read", "/proc/self/attr/smack/*", EINVAL},
 	{"read", "/proc/self/attr/apparmor/*", EINVAL},
+	{"read", "/proc/self/attr/biba/*", EINVAL},
 	{"read", "/proc/self/task/[0-9]*/attr/*", EINVAL},
+	{"read", "/proc/self/task/[0-9]*/attr/biba/*", EINVAL},
 	{"read", "/proc/self/task/[0-9]*/attr/smack/*", EINVAL},
 	{"read", "/proc/self/task/[0-9]*/attr/selinux/*", EINVAL},
 	{"read", "/proc/self/task/[0-9]*/attr/apparmor/*", EINVAL},
-- 
2.43.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] proc01: whitelist biba attr files returning EINVAL

[Cyril Hrubis]

Hi!
> proc01 already treats several attr files under /proc/self/attr and
> /proc/self/task/*/attr as known exceptions that may return EINVAL
> on read.
> 
> On systems exposing biba attr files, reads from
> /proc/self/attr/biba/* and /proc/self/task/*/attr/biba/* also
> return EINVAL, which makes proc01 report false failures.

What is biba? There does not seem to be any mention of string 'biba' in
upstream kernel. As a rule we do not add any fixes for out-of-tree
patches to LTP.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] proc01: whitelist biba attr files returning EINVAL

[Petr Vorel]

> Hi!
> > proc01 already treats several attr files under /proc/self/attr and
> > /proc/self/task/*/attr as known exceptions that may return EINVAL
> > on read.

> > On systems exposing biba attr files, reads from
> > /proc/self/attr/biba/* and /proc/self/task/*/attr/biba/* also
> > return EINVAL, which makes proc01 report false failures.

> What is biba? There does not seem to be any mention of string 'biba' in
> upstream kernel. As a rule we do not add any fixes for out-of-tree
> patches to LTP.

+1, I was going to ask the same. Moreover, there is not even out-of-tree code
publicly available.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] proc01: whitelist biba attr files returning EINVAL

[Petr Vorel]

Patch resent 2x, setting the same status as on the first one:
https://lore.kernel.org/ltp/20260404014047.993528-1-wangming01@loongson.cn/
https://patchwork.ozlabs.org/project/ltp/patch/20260404014047.993528-1-wangming01@loongson.cn/

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp