Re: [LTP] sched_football: fix false failures on many-CPU systems

[linuxtestproject.agent@gmail.com]

Hi Soma,

On Sun, 12 Apr 2026 13:13:08 +0000, Soma Das wrote:
> sched_football: fix false failures on many-CPU systems
>
> On large SMP systems with CONFIG_RT_GROUP_SCHED=n, four independent
> issues cause false failures.
>
> 1. RT throttling...
> 2. Offense and defense threads were unpinned...
> 3. game_over was never reset between iterations...
> 4. sched_setscheduler() failure for the referee was silently ignored.

The commit message itself describes these as four independent issues.
Please split into four separate commits so bisection and backporting
work correctly. At minimum, fixes 3 (game_over reset between -i
iterations) and 4 (sched_setscheduler error check) are fully orthogonal
to the RT-throttling and CPU-affinity changes and must be separate
patches.

[...]

> +	SAFE_FILE_SCANF("/proc/sys/kernel/sched_rt_runtime_us", "%ld",
> +			&saved_rt_runtime_us);
> ...
> +	SAFE_FILE_PRINTF("/proc/sys/kernel/sched_rt_runtime_us", "%ld", -1L);

Consider using .save_restore in struct tst_test instead of manual
save/restore in setup/cleanup — it is the idiomatic LTP approach for
/proc/sys knobs.

---
Note:

Our agent completed the review of the patch. The agent can sometimes
produce false positives although often its findings are genuine. If you
find issues with the review, please comment this email or ignore the
suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp