public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: linuxtestproject.agent@gmail.com
To: Sachin Sant <sachinp@linux.ibm.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] io_uring: Add test for READV and WRITEV operations
Date: Thu, 16 Apr 2026 08:02:57 +0000	[thread overview]
Message-ID: <20260416080257.4077-1-linuxtestproject.agent@gmail.com> (raw)
In-Reply-To: <20260416062302.15804-1-sachinp@linux.ibm.com>

Hi Sachin,

On Thu, 16 Apr 2026, Sachin Sant wrote:
> io_uring: Add test for READV and WRITEV operations

> Additionally merge io_uring_init_buffer_pattern() into unified
> init_iovec_buffers() function that supports both rotating and
> simple character patterns

This mixes two logical changes in one commit. io_uring_init_buffer_pattern()
was unused by any existing test; its removal should be a separate preceding
commit, e.g. "io_uring: remove unused io_uring_init_buffer_pattern()".

[...]

> +static void setup(void)
> +{
> +	io_uring_setup_supported_by_kernel();
> +	sigemptyset(&sig);
> +	memset(&s, 0, sizeof(s));
> +	io_uring_setup_queue(&s, QUEUE_DEPTH, 0);
> +	init_iovec_buffers(write_iovs, NUM_VECS, 'A', 1);
> +	clear_iovec_buffers(read_iovs, NUM_VECS);
> +}

read_iovs is modified by READV in run() but only cleared in setup(). With
-i, the second iteration starts with stale data. Add
clear_iovec_buffers(read_iovs, NUM_VECS) at the top of run().

---
Note:

Our agent completed the review of the patch. The full review can be
found at: https://patchwork.ozlabs.org/project/ltp/list/?series=500082

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2026-04-16  8:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-16  6:23 [LTP] [PATCH v4] io_uring: Add test for READV and WRITEV operations Sachin Sant
2026-04-16  8:02 ` linuxtestproject.agent [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-04-16 12:16 [LTP] [PATCH v6 1/2] " Sachin Sant
2026-04-16 13:47 ` [LTP] " linuxtestproject.agent
2026-04-16  4:25 [LTP] [PATCH v3] " Sachin Sant
2026-04-16  5:37 ` [LTP] " linuxtestproject.agent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260416080257.4077-1-linuxtestproject.agent@gmail.com \
    --to=linuxtestproject.agent@gmail.com \
    --cc=ltp@lists.linux.it \
    --cc=sachinp@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox