Re: [LTP] [PATCH] syscalls: file_attr05: skip ntfs filesystem

[Petr Vorel <pvorel@suse.cz>]

Hi Matt
> Hi Petr,

> > On Apr 9, 2026, at 02:53, Petr Vorel <pvorel@suse.cz> wrote:

> > Hi Matthew,

> >> LTP mounts ntfs via ntfs-3g (FUSE) rather than the kernel ntfs3
> >> driver. ntfs-3g's ntfs_ioctl() returns EINVAL for any unhandled
> >> ioctl, including FS_IOC_FSSETXATTR, so file_setattr() returns
> >> EINVAL instead of the expected EOPNOTSUPP.

> >> Add "ntfs" to skip_filesystems for the same reason "fuse" is
> >> already skipped.

> > Reviewed-by: Petr Vorel <pvorel@suse.cz>
> > Good catch, thanks!

> I appreciate the review!

You're welcome, thanks for your contributions!

> > We did not notice, because we have ntfs3 blacklisted in openSUSE Tumbleweed:

...
> >> diff --git a/testcases/kernel/syscalls/file_attr/file_attr05.c b/testcases/kernel/syscalls/file_attr/file_attr05.c
> >> index 6c1471da33e7..85b6cafc5f17 100644
> >> --- a/testcases/kernel/syscalls/file_attr/file_attr05.c
> >> +++ b/testcases/kernel/syscalls/file_attr/file_attr05.c
> >> @@ -49,6 +49,7 @@ static struct tst_test test = {
> >> .skip_filesystems = (const char *const []) {
> >> "xfs",
> >> "fuse", /* EINVAL is raised before EOPNOTSUPP */
> >> + "ntfs", /* mounted via ntfs-3g (FUSE), returns EINVAL */
> > For me it'd work to replace "fuse" with "ntfs" (i.e. remove "fuse").
> > Does it work for you as well, or you need to have blacklisted both?

> Regarding replacing "fuse" with "ntfs": on Ubuntu, ntfs3 is available
> as a kernel module, so the detection reports "Kernel supports ntfs”
> and the FUSE skip path never fires — meaning "fuse" alone doesn’t
> catch it. Removing "fuse" would also drop coverage of other
> FUSE-based filesystems, so I'd prefer to keep both entries.

I actually think that other fuse implementations work, fuse was probably added
to fix ntfs. Or am I wrong? But that can be solved as a separate effort, I don't
want to block what you plan to fix.

Kind regards,
Petr

> -matt

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp