From: linuxtestproject.agent@gmail.com
To: Andrea Cervesato <andrea.cervesato@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] lib: add safe macros for stream testing suite
Date: Thu, 16 Apr 2026 15:34:37 +0000 [thread overview]
Message-ID: <20260416153437.4144-1-linuxtestproject.agent@gmail.com> (raw)
In-Reply-To: <20260416-stream_refactoring-v2-1-8321b1ec6f68@suse.com>
Hi Andrea,
--- [PATCH 3/7] ---
On Thu, 16 Apr 2026 16:33:37 +0200, Andrea Cervesato wrote:
> lib: add TST_EXP_PASS_PTR_NULL() macro
This lib commit is sandwiched between stream01 and stream02 test commits.
All library helper additions should come before the test rewrites that
depend on them.
--- [PATCH 5/7] ---
On Thu, 16 Apr 2026 16:33:39 +0200, Andrea Cervesato wrote:
> fs: rewrite stream03 test using new API
> + rewind(stream);
> + TST_EXP_EQ_LI(SAFE_FTELL(stream), SEEK_SET);
SEEK_SET is a whence-direction constant (== 0), not a byte offset.
Use 0 here instead.
---
Note:
Our agent completed the review of the patch. The full review can be
found at: https://patchwork.ozlabs.org/project/ltp/list/?series=500172
The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-04-16 15:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-16 14:33 [LTP] [PATCH v2 0/7] Rewrite fs stream testing suite Andrea Cervesato
2026-04-16 14:33 ` [LTP] [PATCH v2 1/7] lib: add safe macros for " Andrea Cervesato
2026-04-16 15:34 ` linuxtestproject.agent [this message]
2026-04-16 14:33 ` [LTP] [PATCH v2 2/7] fs: rewrite stream01 test using new API Andrea Cervesato
2026-04-16 15:26 ` Cyril Hrubis
2026-04-16 14:33 ` [LTP] [PATCH v2 3/7] lib: add TST_EXP_PASS_PTR_NULL() macro Andrea Cervesato
2026-04-16 15:15 ` Cyril Hrubis
2026-04-16 14:33 ` [LTP] [PATCH v2 4/7] fs: rewrite stream02 test using new API Andrea Cervesato
2026-04-16 15:32 ` Cyril Hrubis
2026-04-16 14:33 ` [LTP] [PATCH v2 5/7] fs: rewrite stream03 " Andrea Cervesato
2026-04-16 14:33 ` [LTP] [PATCH v2 6/7] fs: rewrite stream04 " Andrea Cervesato
2026-04-16 14:33 ` [LTP] [PATCH v2 7/7] fs: rewrite stream05 " Andrea Cervesato
2026-04-16 18:21 ` [LTP] [PATCH v2 0/7] Rewrite fs stream testing suite Andrea Cervesato via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260416153437.4144-1-linuxtestproject.agent@gmail.com \
--to=linuxtestproject.agent@gmail.com \
--cc=andrea.cervesato@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox