From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 32DCFF43696 for ; Fri, 17 Apr 2026 11:57:10 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id DCD593E5942 for ; Fri, 17 Apr 2026 13:57:08 +0200 (CEST) Received: from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [217.194.8.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 3F98D3CCB72 for ; Fri, 17 Apr 2026 13:56:51 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-3.smtp.seeweb.it (Postfix) with ESMTPS id B40E01A00780 for ; Fri, 17 Apr 2026 13:56:50 +0200 (CEST) Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C42146A9B2; Fri, 17 Apr 2026 11:56:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1776427009; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v9ZrtGIebQv3U9QlCAvGC8OI/7kRFg9nsPZgdqeaA7k=; b=iPzqj70Y2sq/H8XaH0W/jdMvndM+XvJB8R89U3GA1VlRl/XRx9Ny6vxtf6JuzPIJouD2kW ybGnVNhpxqVtSGkNLOyatzn61CiA6kN+2yTGGYcnGAYoDZ5qntFrzRSR3Je+FcQKR7ctmJ bOcICH3TMDhLLbxZPR9LtloSmMJe428= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1776427009; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v9ZrtGIebQv3U9QlCAvGC8OI/7kRFg9nsPZgdqeaA7k=; b=UIW4CEq6/tkykMZUdaX6ypE9rVeC5tN68O35gtFLAB0EBy22xJwfrhZeSVU15yXrC/bw85 CfrQl9ccof24c+Dw== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1776427009; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v9ZrtGIebQv3U9QlCAvGC8OI/7kRFg9nsPZgdqeaA7k=; b=iPzqj70Y2sq/H8XaH0W/jdMvndM+XvJB8R89U3GA1VlRl/XRx9Ny6vxtf6JuzPIJouD2kW ybGnVNhpxqVtSGkNLOyatzn61CiA6kN+2yTGGYcnGAYoDZ5qntFrzRSR3Je+FcQKR7ctmJ bOcICH3TMDhLLbxZPR9LtloSmMJe428= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1776427009; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v9ZrtGIebQv3U9QlCAvGC8OI/7kRFg9nsPZgdqeaA7k=; b=UIW4CEq6/tkykMZUdaX6ypE9rVeC5tN68O35gtFLAB0EBy22xJwfrhZeSVU15yXrC/bw85 CfrQl9ccof24c+Dw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8E670593AE; Fri, 17 Apr 2026 11:56:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id vBD0HgEg4ml9DwAAD6G6ig (envelope-from ); Fri, 17 Apr 2026 11:56:49 +0000 Date: Fri, 17 Apr 2026 13:56:48 +0200 From: Petr Vorel To: Jinseok Kim Message-ID: <20260417115648.GC409289@pevik> References: <20260413204519.GB153189@pevik> <20260416125554.2920-1-always.starving0@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260416125554.2920-1-always.starving0@gmail.com> X-Spamd-Result: default: False [-3.50 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_RHS_NOT_FQDN(0.50)[]; HAS_REPLYTO(0.30)[pvorel@suse.cz]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_ALL(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MISSING_XM_UA(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; TAGGED_RCPT(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[gmail.com,lists.linux.it]; FREEMAIL_TO(0.00)[gmail.com]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.cz:replyto,imap1.dmz-prg2.suse.org:helo]; RCPT_COUNT_THREE(0.00)[3]; REPLYTO_EQ_FROM(0.00)[] X-Virus-Scanned: clamav-milter 1.0.9 at in-3.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v4] close02: add test for double close EBADF X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi Jinseok, ... > -static void run(void) > +static struct tcase { > + const char *desc; > + int fd; > + int exp_errno; > +} tcases[] = { > + { "close(-1)", -1, EBADF }, > + { "close same fd twice", -1, EBADF }, > +}; > + > +static void verify_close(unsigned int i) > +{ > + struct tcase *tc = &tcases[i]; > + > + TST_EXP_FAIL(close(tc->fd), tc->exp_errno, "%s", tc->desc); > +} > + > +static void setup(void) > { > - TST_EXP_FAIL(close(-1), EBADF); > + int fd = SAFE_OPEN("close02", O_CREAT | O_RDWR, 0600); > + > + SAFE_CLOSE(fd); > + tcases[1].fd = fd; Depending on index is error-prone. I know that test array has only 2 members, but could you please use our usual approach to use file descriptors as static? See fd_ebadf and fd_enotdir in testcases/kernel/syscalls/bind/bind01.c. Kind regards, Petr -- Mailing list info: https://lists.linux.it/listinfo/ltp