public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: linuxtestproject.agent@gmail.com
To: Andrea Cervesato <andrea.cervesato@suse.de>
Cc: ltp@lists.linux.it, LTP AI Reviewer <ltp-ai@noreply.github.com>
Subject: Re: [LTP] lapi: Add fallback rdma_user_cm.h definitions
Date: Fri, 17 Apr 2026 12:02:07 +0000	[thread overview]
Message-ID: <20260417120207.3845-1-linuxtestproject.agent@gmail.com> (raw)
In-Reply-To: <20260325-infiniband_rdma-v1-1-9c1bd3e69d29@suse.com>

Hi Andrea,

On Wed, 25 Mar 2026, Andrea Cervesato wrote:
> lapi: Add fallback rdma_user_cm.h definitions

> +#ifdef HAVE_RDMA_RDMA_USER_CM_H
> +# include <rdma/rdma_user_cm.h>
> +#endif
> +
> +#ifndef RDMA_USER_CM_ABI_VERSION

Correct lapi pattern — configure check + fallback guard under
RDMA_USER_CM_ABI_VERSION.

[...]

> device-drivers/rdma: Add ucma_uaf01 test

> +	while (tst_remaining_runtime())
> +		sleep(1);

Standard runtime-loop idiom, not synchronization — fine.

[...]

> +	.taint_check = TST_TAINT_W | TST_TAINT_D,
> +	.needs_kconfigs = (const char *[]) {
> +		"CONFIG_INFINIBAND",
> +		"CONFIG_INFINIBAND_USER_ACCESS",
> +		NULL
> +	},

Good use of needs_kconfigs to skip cleanly on systems without RDMA
support.

Reviewed-by: LTP AI Reviewer <ltp-ai@noreply.github.com>

---
Note:

Our agent completed the review of the patch.

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2026-04-17 12:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-25 15:25 [LTP] [PATCH 0/2] Add infiniband testing suite Andrea Cervesato
2026-03-25 15:25 ` [LTP] [PATCH 1/2] lapi: Add fallback rdma_user_cm.h definitions Andrea Cervesato
2026-04-17 12:02   ` linuxtestproject.agent [this message]
2026-03-25 15:25 ` [LTP] [PATCH 2/2] device-drivers/rdma: Add ucma_uaf01 test Andrea Cervesato
2026-04-07 13:24   ` Petr Vorel
2026-04-12 14:14     ` Leon Romanovsky via ltp
2026-04-14  7:30       ` Petr Vorel
2026-04-14  9:17         ` Leon Romanovsky via ltp
2026-04-08  7:16   ` Petr Vorel
2026-04-07 12:56 ` [LTP] [PATCH 0/2] Add infiniband testing suite Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260417120207.3845-1-linuxtestproject.agent@gmail.com \
    --to=linuxtestproject.agent@gmail.com \
    --cc=andrea.cervesato@suse.de \
    --cc=ltp-ai@noreply.github.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox