public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: linuxtestproject.agent@gmail.com
Cc: ltp@lists.linux.it
Subject: Re: [LTP] OpenPOSIX: Add common entry point function for all tests
Date: Fri, 17 Apr 2026 15:09:20 +0200	[thread overview]
Message-ID: <20260417130920.GA420978@pevik> (raw)
In-Reply-To: <20260416183620.4076-1-linuxtestproject.agent@gmail.com>

Hi Martin,

> Hi Martin,

> On Thu, 16 Apr 2026, Martin Doucha wrote:
> > OpenPOSIX: Add common entry point function for all tests

> > Add a new shared source file implementing the main() function and rename
> > the existing main() functions in test case sources to test_main(). This
> > allows adding custom debug code to all test cases at once.

> [...]

> > diff --git a/testcases/open_posix_testsuite/conformance/interfaces/pthread_create/assertions.xml b/...
> > -  NOTE: that the thread in which main() was originally invoked is different
> > +  NOTE: that the thread in which test_main() was originally invoked is different

> This changes verbatim POSIX specification text. The assertions.xml files
> quote the POSIX standard, which defines behaviour relative to main() — the C
> entry point, not an LTP-internal function name. Revert these hunks in both
> pthread_create/assertions.xml and pthread_exit/assertions.xml.

+1

> > diff --git a/.../aio_write/9-2.c b/.../aio_write/9-2.c
> > +int test_main(int argc, char** argv)

> s/char** argv/char **argv/ to match the style used everywhere else.

+1

@Martin, will you please send v2?

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2026-04-17 13:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260416144213.27221-1-mdoucha@suse.cz>
2026-04-16 18:36 ` [LTP] OpenPOSIX: Add common entry point function for all tests linuxtestproject.agent
2026-04-17 13:09   ` Petr Vorel [this message]
2026-04-17 13:35     ` Martin Doucha
2026-04-17 14:44       ` Petr Vorel
2026-04-17 14:33     ` Petr Vorel
2026-04-16 18:53 ` [LTP] [PATCH] " Petr Vorel
2026-04-17  0:30   ` Li Wang via ltp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260417130920.GA420978@pevik \
    --to=pvorel@suse.cz \
    --cc=linuxtestproject.agent@gmail.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox