Re: [LTP] lapi/io_uring: Add IORING_OP_READ/WRITE constants

linuxtestproject.agent
2026-04-20T18:03:00Z

Hi Martin,

On Mon, 20 Apr 2026 18:34:09 +0200, Martin Doucha wrote:
> lapi/io_uring: Add IORING_OP_READ/WRITE constants

> +#ifndef HAVE_IORING_OP_READ
> +#define IORING_OP_READ 22
> +#endif
> +
> +#ifndef HAVE_IORING_OP_WRITE
> +#define IORING_OP_WRITE 23
> +#endif

AC_CHECK_DECLS() defines HAVE_DECL_IORING_OP_READ (to 0 or 1), not
HAVE_IORING_OP_READ. The #ifndef guard is always entered, making the
configure.ac checks dead code. Use #if !HAVE_DECL_IORING_OP_READ and
#if !HAVE_DECL_IORING_OP_WRITE — see include/lapi/landlock.h for the
established pattern.

---
Note:

Our agent completed the review of the patch. The full review can be
found at: https://github.com/linux-test-project/ltp-agent/actions/runs/24682015063

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

--
Mailing list info: https://lists.linux.it/listinfo/ltp