From: linuxtestproject.agent@gmail.com
To: Martin Doucha <mdoucha@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] lapi/io_uring: Add IORING_OP_READ/WRITE constants
Date: Mon, 20 Apr 2026 18:02:28 +0000 [thread overview]
Message-ID: <20260420180228.3934-1-linuxtestproject.agent@gmail.com> (raw)
In-Reply-To: <20260420163433.44646-1-mdoucha@suse.cz>
Hi Martin,
On Mon, 20 Apr 2026 18:34:09 +0200, Martin Doucha wrote:
> lapi/io_uring: Add IORING_OP_READ/WRITE constants
> +#ifndef HAVE_IORING_OP_READ
> +#define IORING_OP_READ 22
> +#endif
> +
> +#ifndef HAVE_IORING_OP_WRITE
> +#define IORING_OP_WRITE 23
> +#endif
AC_CHECK_DECLS() defines HAVE_DECL_IORING_OP_READ (to 0 or 1), not
HAVE_IORING_OP_READ. The #ifndef guard is always entered, making the
configure.ac checks dead code. Use #if !HAVE_DECL_IORING_OP_READ and
#if !HAVE_DECL_IORING_OP_WRITE — see include/lapi/landlock.h for the
established pattern.
---
Note:
Our agent completed the review of the patch. The full review can be
found at: https://github.com/linux-test-project/ltp-agent/actions/runs/24682015063
The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2026-04-20 18:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-20 16:34 [LTP] [PATCH] lapi/io_uring: Add IORING_OP_READ/WRITE constants Martin Doucha
2026-04-20 18:02 ` linuxtestproject.agent [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260420180228.3934-1-linuxtestproject.agent@gmail.com \
--to=linuxtestproject.agent@gmail.com \
--cc=ltp@lists.linux.it \
--cc=mdoucha@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox