Re: [LTP] OpenPOSIX: Add common entry point function for all tests

linuxtestproject.agent
2026-04-16T18:36:48Z

Hi Martin,

On Thu, 16 Apr 2026, Martin Doucha wrote:
> OpenPOSIX: Add common entry point function for all tests
>
> Add a new shared source file implementing the main() function and rename
> the existing main() functions in test case sources to test_main(). This
> allows adding custom debug code to all test cases at once.

[...]

> diff --git a/testcases/open_posix_testsuite/conformance/interfaces/pthread_create/assertions.xml b/...
> - NOTE: that the thread in which main() was originally invoked is different
> + NOTE: that the thread in which test_main() was originally invoked is different

This changes verbatim POSIX specification text. The assertions.xml files
quote the POSIX standard, which defines behaviour relative to main() — the C
entry point, not an LTP-internal function name. Revert these hunks in both
pthread_create/assertions.xml and pthread_exit/assertions.xml.

> diff --git a/.../aio_write/9-2.c b/.../aio_write/9-2.c
> +int test_main(int argc, char** argv)

s/char** argv/char **argv/ to match the style used everywhere else.

---
Note:

Our agent completed the review of the patch. The full review can be
found at: https://patchwork.ozlabs.org/project/ltp/list/?series=500173

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.