Re: [LTP] OpenPOSIX: Add common entry point function for all tests

Petr Vorel
2026-04-17T14:34:05Z

Hi Martin,

> Hi Martin,

> > Hi Martin,

> > On Thu, 16 Apr 2026, Martin Doucha wrote:
> > > OpenPOSIX: Add common entry point function for all tests

> > > Add a new shared source file implementing the main() function and rename
> > > the existing main() functions in test case sources to test_main(). This
> > > allows adding custom debug code to all test cases at once.

> > [...]

> > > diff --git a/testcases/open_posix_testsuite/conformance/interfaces/pthread_create/assertions.xml b/...
> > > - NOTE: that the thread in which main() was originally invoked is different
> > > + NOTE: that the thread in which test_main() was originally invoked is different

> > This changes verbatim POSIX specification text. The assertions.xml files
> > quote the POSIX standard, which defines behaviour relative to main() — the C
> > entry point, not an LTP-internal function name. Revert these hunks in both
> > pthread_create/assertions.xml and pthread_exit/assertions.xml.

> +1

> > > diff --git a/.../aio_write/9-2.c b/.../aio_write/9-2.c
> > > +int test_main(int argc, char** argv)

> > s/char** argv/char **argv/ to match the style used everywhere else.

> +1

> @Martin, will you please send v2?

@Martin, or I can apply the following diff if you agree.

Kind regards,
Petr

> Kind regards,
> Petr

diff --git testcases/open_posix_testsuite/conformance/interfaces/pthread_create/assertions.xml testcases/open_posix_testsuite/conformance/interfaces/pthread_create/assertions.xml
index 9d3cda4d87..7a5e60557d 100644
--- testcases/open_posix_testsuite/conformance/interfaces/pthread_create/assertions.xml
+++ testcases/open_posix_testsuite/conformance/interfaces/pthread_create/assertions.xml
@@ -33,12 +33,12 @@
If the 'start_routine' returns, the effect shall be as if there was an
implicit call to pthread_exit() using the return value of 'start_routine'
as the exit status.
- NOTE: that the thread in which test_main() was originally invoked is different
+ NOTE: that the thread in which main() was originally invoked is different
from this
</assertion>
<assertion id="7" tag="ref:XSH6:32848:32849">
- When it returns from test_main(), the effect shall be as if there was an implicit
- call to exit() using the return value of test_main() as the exit status.
+ When it returns from main(), the effect shall be as if there was an implicit
+ call to exit() using the return value of main() as the exit status.
</assertion>
<assertion id="8" tag="ref:XSH6:32850:32852">
The signal state of the new thread will be initialized as so:
diff --git testcases/open_posix_testsuite/conformance/interfaces/pthread_exit/assertions.xml testcases/open_posix_testsuite/conformance/interfaces/pthread_exit/assertions.xml
index 15d2a09a11..f34f6a197e 100644
--- testcases/open_posix_testsuite/conformance/interfaces/pthread_exit/assertions.xml
+++ testcases/open_posix_testsuite/conformance/interfaces/pthread_exit/assertions.xml
@@ -24,7 +24,7 @@
</assertion>
<assertion id="5" tag="ref:XSH6:33031:33033">
An implicit call to pthread_exit() is made when a thread other than the
- thread in which test_main() was first invoked returns from the start routine that
+ thread in which main() was first invoked returns from the start routine that
was used to create it. The function's return value shall serve as the
thread's exit status.
</assertion>
diff --git testcases/open_posix_testsuite/conformance/interfaces/strcpy/1-1.c testcases/open_posix_testsuite/conformance/interfaces/strcpy/1-1.c
index 441654ed6c..e783fc92ea 100644
--- testcases/open_posix_testsuite/conformance/interfaces/strcpy/1-1.c
+++ testcases/open_posix_testsuite/conformance/interfaces/strcpy/1-1.c
@@ -44,7 +44,7 @@ static char *random_string(int len)
return output_string;
}

-int test_main(int argc, char** argv)
+int test_main(int argc PTS_ATTRIBUTE_UNUSED, char **argv PTS_ATTRIBUTE_UNUSED)
{
char *ret_str;
int i;