From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 156E5F8925C for ; Tue, 21 Apr 2026 11:04:36 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id A19EF3E2D90 for ; Tue, 21 Apr 2026 13:04:34 +0200 (CEST) Received: from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [IPv6:2001:4b78:1:20::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 024673C0224 for ; Tue, 21 Apr 2026 13:04:13 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-3.smtp.seeweb.it (Postfix) with ESMTPS id D5A141A006BB for ; Tue, 21 Apr 2026 13:04:11 +0200 (CEST) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 605C25BCEE; Tue, 21 Apr 2026 11:04:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1776769449; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=caiCCo7dKKV9YLFjtqy2ECOqm2jgbrQcKSzSFizeOHA=; b=0bYDKnzhtdFjDGdyXHYDjJYqcdeyb/aHHBNkx2VsZzGs7x1nnKJEfrx96GIipUBDdaGJoj M6lwHBeO4vm+glvwkaM+7PH6lqWiVRjN4CYrv6h0Pmr07DlFqz/DfV0MpqxJytSZlD6Fga 0D6NAnuGs/MWXWbWZwQevhgfPaEz+RU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1776769449; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=caiCCo7dKKV9YLFjtqy2ECOqm2jgbrQcKSzSFizeOHA=; b=q8Ssj3LyBi/mbhoSmA0Z2FfBIe4F39Fog2jmp2ISOwAuLDrS/4oLTa4dWHJsJkmg1Nflq2 NkqOHkVv+YIgz1CA== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=lHpZtbmE; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Ymn3kIIB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1776769448; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=caiCCo7dKKV9YLFjtqy2ECOqm2jgbrQcKSzSFizeOHA=; b=lHpZtbmElwwOkPZYrxXvRqCEHDkA/4wFVAZ7VsnVcdakhzjPjKbmD29rBD1v7GZL/rJaeP GzoKTlIOMtCgc2yMEQ41WqcJExmLaRbG+Blu1uGZzvPWac47mUdoe2o50KY4xfwRJ8Bme8 nE4CjjeArENncKFz81QmEybjqNJNU+8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1776769448; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=caiCCo7dKKV9YLFjtqy2ECOqm2jgbrQcKSzSFizeOHA=; b=Ymn3kIIBQi1mIuJevg1Kb195gCqVnZarAvskbsS4sg2S/u9dwQRiaQuuRX0+feU0tfYXzo /qFrS0j1MkDKTRCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 433B6593AF; Tue, 21 Apr 2026 11:04:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ZGaQDqhZ52kGfgAAD6G6ig (envelope-from ); Tue, 21 Apr 2026 11:04:08 +0000 Date: Tue, 21 Apr 2026 13:04:06 +0200 From: Petr Vorel To: Cyril Hrubis Message-ID: <20260421110406.GB506589@pevik> References: <20260402121356.31266-1-chrubis@suse.cz> <20260402121356.31266-5-chrubis@suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260402121356.31266-5-chrubis@suse.cz> X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-3.71 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_RHS_NOT_FQDN(0.50)[]; HAS_REPLYTO(0.30)[pvorel@suse.cz]; R_DKIM_ALLOW(-0.20)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; ARC_NA(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; TO_DN_SOME(0.00)[]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.cz:+]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.cz:dkim,suse.cz:replyto,suse.cz:email,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[lists.linux.it,gmail.com]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_VIA_SMTP_AUTH(0.00)[]; TAGGED_RCPT(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; MISSING_XM_UA(0.00)[]; REPLYTO_EQ_FROM(0.00)[] X-Rspamd-Queue-Id: 605C25BCEE X-Virus-Scanned: clamav-milter 1.0.9 at in-3.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH 04/17] lib: tst_kconfig: Add module presence checks X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi Cyril, Li, ... > + if (tst_check_module_driver(module_checks[i].module_name)) { > + tst_res(TINFO, "%s=%c present but module '%s' not installed", > + var->id, var->choice, module_checks[i].module_name); > + var->choice = 'n'; I would consider having defines for 'y', 'm', 'n' to avoid typos. OTOH even kernel code in scripts/kconfig/symbol.c use plain strings (chars) without defines so feel free to ignore. I consider renames suggested by Li slightly better (it's really mapping). Reviewed-by: Petr Vorel Kind regards, Petr -- Mailing list info: https://lists.linux.it/listinfo/ltp