From: linuxtestproject.agent@gmail.com
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] tst_test.h: Convert rest of doc to kerneldoc
Date: Tue, 21 Apr 2026 15:16:59 +0000 [thread overview]
Message-ID: <20260421151700.3873-1-linuxtestproject.agent@gmail.com> (raw)
In-Reply-To: <20260421144126.613547-1-pvorel@suse.cz>
Hi Petr,
On Tue, 21 Apr 2026 16:41:26 +0200, Petr Vorel wrote:
> tst_test.h: Convert rest of doc to kerneldoc
The commit message body is missing. Please add at least one sentence
explaining why this conversion is being done (e.g. to enable Sphinx
kerneldoc extraction).
> +/**
> + * tst_set_timeout() - Sets the timeout part of the overall timeout.
> + *
[...]
> + * @timeout: A timeout in seconds, defines the total time allowed for a single
> + * test iteration, including the setup, runtime, and teardown phases.
The @timeout description is inaccurate. The implementation computes:
overall_time = tst_multiply_timeout(DEFAULT_TIMEOUT + timeout) + context->runtime
So @timeout is not the total time per iteration — it is added to
DEFAULT_TIMEOUT before multiplication, and the runtime portion is added
separately. The description should reflect what the argument actually
controls, not the resulting overall_time.
---
Note:
Our agent completed the review of the patch.
The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2026-04-21 15:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-21 14:41 [LTP] [PATCH v2 1/1] tst_test.h: Convert rest of doc to kerneldoc Petr Vorel
2026-04-21 15:16 ` linuxtestproject.agent [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260421151700.3873-1-linuxtestproject.agent@gmail.com \
--to=linuxtestproject.agent@gmail.com \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox