Re: [LTP] [PATCH v5] close02: add test for double close EBADF

[Petr Vorel <pvorel@suse.cz>]

Hi Jinseok,

> Verify that calling close() on an already closed file descriptor fails
> with EBADF.

> This test adds coverage for a common state transition case where a
> previously valid file descriptor becomes invalid after close().

> Signed-off-by: Jinseok Kim <always.starving0@gmail.com>
> ---
> Changes in v5:
> - Change file descriptor as static
Well, I asked for static pointer.

> - Link to v4 : https://lore.kernel.org/ltp/20260416125554.2920-1-always.starving0@gmail.com

> Changes in v4:
> - Remove enum, add fd/expected errno in tcases, and move preparation
>   to setup().
> - Link to v3: https://lore.kernel.org/ltp/20260413165457.1349-1-always.starving0@gmail.com

> Changes in v3:
> - Add O_RDWR flag to SAFE_OPEN
> - Link to v2: https://lore.kernel.org/ltp/20260411110405.7330-1-always.starving0@gmail.com

> Changes in v2:
> - Add additional test coverage to close02 instead of creating a separate
>   close03 test.
> - Link to v1: https://lore.kernel.org/ltp/20260406133134.17238-2-always.starving0@gmail.com
> ---
>  testcases/kernel/syscalls/close/close02.c | 37 ++++++++++++++++++++---
>  1 file changed, 33 insertions(+), 4 deletions(-)

> diff --git a/testcases/kernel/syscalls/close/close02.c b/testcases/kernel/syscalls/close/close02.c
> index 617c48237..a48570d12 100644
> --- a/testcases/kernel/syscalls/close/close02.c
> +++ b/testcases/kernel/syscalls/close/close02.c
> @@ -5,17 +5,46 @@
>   */

>  /*\
> - * Call close(-1) and expects it to return EBADF.
> + * Verify :manpage:`close(2)` failure cases:
> + *
> + * 1) close(-1) returns EBADF.
> + * 2) closing the same fd twice returns EBADF on the second call.
>   */

>  #include <errno.h>
> +#include <fcntl.h>
> +
>  #include "tst_test.h"

> -static void run(void)
> +static int fd_closed = -1;
> +
> +static struct tcase {
> +	const char *desc;
> +	int fd;

ie instead of "int fd" define:
	int *fd;

> +	int exp_errno;
> +} tcases[] = {
> +	{ "close(-1)", -1, EBADF },
> +	{ "close same fd twice", -1, EBADF },
> +};
> +
> +static void verify_close(unsigned int i)
>  {
> -	TST_EXP_FAIL(close(-1), EBADF);
> +	struct tcase *tc = &tcases[i];
> +
> +	TST_EXP_FAIL(close(tc->fd), tc->exp_errno, "%s", tc->desc);
> +}
> +
> +static void setup(void)
> +{
> +	fd_closed = SAFE_OPEN("close02", O_CREAT | O_RDWR, 0600);
> +
> +	SAFE_CLOSE(fd_closed);
> +	tcases[1].fd = fd_closed;

We're getting there but not yet :).  My point was not to assign file descriptor
here in the setup function, but above in tcases[] array. For that you need to
define in struct tcases "int *fd" (i.e. pointer) instead of "int fd".

I pointed in v4 testcases/kernel/syscalls/bind/bind01.c, which uses
int *socket_fd, could you do it that way (use pointer)?

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp