Re: [LTP] [PATCH v5 6/6] lib: Print TCONF on LTP_REPRODUCIBLE_OUTPUT=1

[Petr Vorel <pvorel@suse.cz>]

Hi,

[ Cc valgrind-developers ML, which I should have done when sending the patchset ].

Kind regards,
Petr

> It'll be better for Valgrind developers to know, that test is skipped.
> TCONF is not printed that often and because output of the message is
> trimmed, it will not be that disruptive.

> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> New in v5 (it can be squashed, but I wanted to point this out and get Martin's ack).

>  doc/users/setup_tests.rst | 6 +++---
>  lib/tst_test.c            | 4 +---
>  2 files changed, 4 insertions(+), 6 deletions(-)

> diff --git a/doc/users/setup_tests.rst b/doc/users/setup_tests.rst
> index 491a5b003a..43573c8fb1 100644
> --- a/doc/users/setup_tests.rst
> +++ b/doc/users/setup_tests.rst
> @@ -43,9 +43,9 @@ users.
>         Shell language: ``TST_NEEDS_DEVICE=1``.

>     * - LTP_REPRODUCIBLE_OUTPUT
> -     - When set to ``1`` or ``y`` uppress printing TCONF, TINFO and TDEBUG
> -       messages and discards the actual content of the other messages printed
> -       by the test (suitable for a reproducible output).
> +     - When set to ``1`` or ``y`` uppress printing TINFO and TDEBUG messages
> +       and discards the actual content of the other messages printed by the
> +       test (suitable for a reproducible output).

>     * - LTP_SINGLE_FS_TYPE
>       - Specifies single filesystem to run the test on instead all supported
> diff --git a/lib/tst_test.c b/lib/tst_test.c
> index a0b55049ff..469a3f6b65 100644
> --- a/lib/tst_test.c
> +++ b/lib/tst_test.c
> @@ -306,8 +306,6 @@ static void print_result(const char *file, const int lineno, int ttype,
>  		res = "TBROK";
>  	break;
>  	case TCONF:
> -		if (reproducible_output)
> -			return;
>  		res = "TCONF";
>  	break;
>  	case TWARN:
> @@ -675,7 +673,7 @@ static void print_help(void)
>  	fprintf(stderr, "LTP_DEV                  Path to the block device to be used (for .needs_device)\n");
>  	fprintf(stderr, "LTP_DEV_FS_TYPE          Filesystem used for testing (default: %s)\n", DEFAULT_FS_TYPE);
>  	fprintf(stderr, "LTP_DEBUG                Print debug messages (set 1(y) or 2)\n");
> -	fprintf(stderr, "LTP_REPRODUCIBLE_OUTPUT  Values 1 or y suppress printing TCONF, TINFO and TDEBUG messages and\n"
> +	fprintf(stderr, "LTP_REPRODUCIBLE_OUTPUT  Values 1 or y suppress printing TINFO and TDEBUG messages and\n"
>  			"                         discards the actual content of all other messages\n");
>  	fprintf(stderr, "LTP_SINGLE_FS_TYPE       Specifies filesystem instead all supported (for .all_filesystems)\n");
>  	fprintf(stderr, "LTP_FORCE_SINGLE_FS_TYPE Testing only. The same as LTP_SINGLE_FS_TYPE but ignores test skiplist.\n");

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp