Re: [LTP] syscalls: Add epoll_create03

[linuxtestproject.agent@gmail.com]

Hi Cyril,

--- [PATCH 3/8] ---

On 2026-04-23, Cyril Hrubis wrote:
> syscalls: Add epoll_wait09

> -epoll_wait08 epoll_wait08
> +epoll_wait09 epoll_wait09

This replaces the epoll_wait08 entry instead of adding epoll_wait09
alongside it. epoll_wait08 will be built but never run.

> That checks that events from recursive epoll are propagated correctly.

"That checks..." is a dangling clause; the body must stand alone as a
sentence (e.g. "Test that checks...").

--- [PATCH 5/8] ---

On 2026-04-23, Cyril Hrubis wrote:
> syscall: Add epoll_wait10

Prefix typo: "syscall:" should be "syscalls:" (all other patches in
this series use "syscalls:").

--- [PATCH 6/8] ---

On 2026-04-23, Cyril Hrubis wrote:
> syscalls: Add epoll_wait11
>
> A test that chcecks that EPOLLHUP is generated properly [...]

Typo: "chcecks" -> "checks".

> +	TST_PROCESS_STATE_WAIT(pid, 'S', 0);
> +	SAFE_CLOSE(fds[1]);
> +	SAFE_CLOSE(fds[0]);
> +	SAFE_CLOSE(efd);
> +}
> +
> +static void cleanup(void)
> +{
> +	if (fds[1] > 0)
> +		SAFE_CLOSE(fds[1]);

fds[] and efd are closed in run() but not reset to -1; cleanup() then
double-closes them on every run (TBROK). Reset each to -1 after
SAFE_CLOSE in run(), and use != -1 guards in cleanup() per LTP
convention.

--- [PATCH 7/8] ---

On 2026-04-23, Cyril Hrubis wrote:
> +	TST_PROCESS_STATE_WAIT(pid, 'S', 0);
> +	SAFE_CLOSE(fds[0]);
> +	SAFE_CLOSE(fds[1]);
> +	SAFE_CLOSE(efd);
> +}
> +
> +static void cleanup(void)
> +{
> +	if (fds[1] > 0)
> +		SAFE_CLOSE(fds[1]);

Same double-close defect as epoll_wait11; apply the same fix.

---
Note:

Our agent completed the review of the patch. The full review can be
found at: https://github.com/linux-test-project/ltp-agent/actions/runs/24831850683

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp