From: linuxtestproject.agent@gmail.com
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it, LTP AI Reviewer <ltp-ai@noreply.github.com>
Subject: Re: [LTP] ima_violations.sh: Wait for ima_mmap to exit
Date: Tue, 28 Apr 2026 16:59:51 +0000 [thread overview]
Message-ID: <20260428165951.3950-1-linuxtestproject.agent@gmail.com> (raw)
In-Reply-To: <20260428161034.947614-1-pvorel@suse.cz>
Hi Petr,
On Tue, Apr 28, 2026 at 18:10:33 +0200, Petr Vorel wrote:
> ima_violations.sh: Wait for ima_mmap to exit
> ima_violations.sh: ima_mmap.c: Replace sleep with checkpoints
Both patches look good.
Reviewed-by: LTP AI Reviewer <ltp-ai@noreply.github.com>
Pre-existing issues noticed in the surrounding code (not introduced
by this patch):
- ima_mmap.c:2-8 — no doc comment describing the test; only a copyright block present
- ima_violations.sh — missing # --- doc and # --- env blocks
- ima_mmap.c:18-25 — cleanup() does not set file = NULL after SAFE_MUNMAP
---
Note:
Our agent completed the review of the patch. The full review can be
found at: https://github.com/linux-test-project/ltp-agent/actions/runs/25066130804
The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-04-28 17:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-28 16:10 [LTP] [PATCH 1/2] ima_violations.sh: Wait for ima_mmap to exit Petr Vorel
2026-04-28 16:10 ` [LTP] [PATCH 2/2] ima_violations.sh: ima_mmap.c: Replace sleep with checkpoints Petr Vorel
2026-04-29 11:15 ` Martin Doucha
2026-04-29 12:00 ` Petr Vorel
2026-04-30 9:16 ` Cyril Hrubis
2026-04-28 16:59 ` linuxtestproject.agent [this message]
2026-04-30 9:03 ` [LTP] [PATCH 1/2] ima_violations.sh: Wait for ima_mmap to exit Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260428165951.3950-1-linuxtestproject.agent@gmail.com \
--to=linuxtestproject.agent@gmail.com \
--cc=ltp-ai@noreply.github.com \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox