Re: [LTP] testcases/nvme: Add NVMe device discovery and identification test

[linuxtestproject.agent@gmail.com]

Hi Priya,

On Thu, 30 Apr 2026 15:48:52 +0000, priyama2 wrote:
> testcases/nvme: Add NVMe device discovery and identification test
>
> This test verifies NVMe device discovery and identification by:
> - Detecting NVMe controllers in /dev
> [...]

The commit body describes what the test does but not why it is needed —
what coverage gap does this fill? Also, "Changes in v2:" belongs in the
cover letter, not the commit body; strip it before sending.

> +++ b/testcases/kernel/device-drivers/nvme/nvme01
> new file mode 100755
>  Bin 0 -> 995536 bytes

Do not commit compiled binaries. Remove nvme01 from the patch and add a
.gitignore in the test directory listing it.

> + * Copyright (c) 2024 IBM Corporation

This file is new and added in 2026; use the current year.

> +static int nvme_device_found;
> +static char nvme_dev_name[256];

These statics are set in case 0 of run() but never cleared. With -i,
stale state from a prior iteration persists into subsequent ones. Reset
them at the top of run().

> +	.needs_root = 1,

No operation in this test requires root. All reads from /dev and sysfs
are accessible to unprivileged users. Drop needs_root.

The patch is also missing a runtest entry (e.g. in runtest/drivers) and
a .gitignore entry for the nvme01 binary.

---
Note:

Our agent completed the review of the patch.

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp