Re: [LTP] aio_cancel: Fix incorrect strerror() usage

[linuxtestproject.agent@gmail.com]

Hi Martin,

--- [PATCH 2/2] ---

On Wed, 29 Apr 2026 16:53:12 +0200, Martin Doucha wrote:
> aio_cancel_6-1: Rewrite test
>
> The test schedules multiple async writes into a file and then hopes that
> at least one will block long enough that aio_cancel() will cancel it.
> [...]
> This fixes a race condition where aio_cancel() could be called after the
> target write has already finished. [...]
>
> Signed-off-by: Martin Doucha <mdoucha@suse.cz>

The commit body says this fixes a race condition, so a Fixes: tag is
required. Patch 1/2 in this same series correctly uses Fixes: tags for
analogous rewrite-as-bugfix commits to 5-1.c and 7-1.c. Please add a
Fixes: referencing the commit that introduced the original 6-1.c.

Pre-existing issues noticed in the surrounding code (not introduced
by this patch):

- aio_cancel/5-1.c — Uses nanosleep() in a spin-wait loop for
  synchronization.

---
Note:

Our agent completed the review of the patch. The full review can be
found at: https://patchwork.ozlabs.org/project/ltp/list/?series=502088

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp