From: linuxtestproject.agent@gmail.com
To: Piotr Kubaj <piotr.kubaj@intel.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] cpufreq.c: add new test for cpufreq sysfs interface validation
Date: Wed, 6 May 2026 12:47:37 +0000 [thread overview]
Message-ID: <20260506124737.3866-1-linuxtestproject.agent@gmail.com> (raw)
In-Reply-To: <20260506091035.59822-2-piotr.kubaj@intel.com>
Hi Piotr,
On Wed, 6 May 2026, Piotr Kubaj wrote:
> cpufreq.c: add new test for cpufreq sysfs interface validation
> + tst_res(TDEBUG, "Checking whether scaling_available_governors contains \"performance\" and \"schedutil\" after switching /sys/devices/system/cpu/intel_pstate/status to \"passive\"");
> + snprintf(path, sizeof(path), "/sys/devices/system/cpu/intel_pstate/status");
> + SAFE_FILE_PRINTF(path, "passive");
> +
> + for (int i = 0; i < nproc; i++) {
> + ...
> + SAFE_FILE_PRINTF(path, "schedutil");
> + ...
> + }
> +}
run() exits with intel_pstate/status still "passive" and each CPU's
scaling_governor still "schedutil". On the second iteration (-i 2) the
status check fires TFAIL immediately, and the governor branch hits
tst_brk(TBROK, "Unknown scaling_governor: schedutil").
Restore the status to "active" and the governors to previous_scaling_governor[i]
at the end of run() before it returns.
[...]
---
Note:
Our agent completed the review of the patch. The full review can be
found at: https://patchwork.ozlabs.org/project/ltp/list/?series=502943
The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-05-06 12:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 9:10 [LTP] [PATCH v6] cpufreq.c: add new test for cpufreq sysfs interface validation Piotr Kubaj
2026-05-06 12:47 ` linuxtestproject.agent [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-05-07 11:11 [LTP] [PATCH v8] " Piotr Kubaj
2026-05-07 11:57 ` [LTP] " linuxtestproject.agent
2026-05-06 13:08 [LTP] [PATCH v7] " Piotr Kubaj
2026-05-06 14:17 ` [LTP] " linuxtestproject.agent
2026-05-05 11:02 [LTP] [PATCH v5] " Piotr Kubaj
2026-05-05 17:53 ` [LTP] " linuxtestproject.agent
2026-05-05 9:48 [LTP] [PATCH v4] " Piotr Kubaj
2026-05-05 10:53 ` [LTP] " linuxtestproject.agent
2026-05-04 10:08 [LTP] [PATCH v3] " Piotr Kubaj
2026-05-04 11:54 ` [LTP] " linuxtestproject.agent
2026-04-22 10:35 [LTP] [PATCH] " Piotr Kubaj
2026-04-22 11:11 ` [LTP] " linuxtestproject.agent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260506124737.3866-1-linuxtestproject.agent@gmail.com \
--to=linuxtestproject.agent@gmail.com \
--cc=ltp@lists.linux.it \
--cc=piotr.kubaj@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox