Re: [LTP] high_freq_hwp_cap_cppc.c: new test

[linuxtestproject.agent@gmail.com]

Hi Piotr,

On Wed, 6 May 2026 14:56:51 +0200, Piotr Kubaj wrote:
> [PATCH] high_freq_hwp_cap_cppc.c: new test

> +static int *mismatch;
[...]
> +		if (msr_highest_perf != sysfs_highest_perf) {
> +			tst_res(TINFO, "cpu%d: sysfs=%llu MSR=%llu",
> +				i, sysfs_highest_perf, msr_highest_perf);
> +			mismatch[i] = 1;

`mismatch[]` is zeroed by SAFE_CALLOC in setup() but never cleared at the
start of run(). With -i N, stale flags from a prior iteration persist and
the per-CPU summary falsely reports "MISMATCH" for CPUs that are now
matching. Add:

    memset(mismatch, 0, nproc * sizeof(*mismatch));

at the top of run().

---
Note:

Our agent completed the review of the patch.

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp