Re: [LTP] io_uring: Add io_uring04 test for vectored I/O operations

[linuxtestproject.agent@gmail.com]

Hi Sachin,

--- [PATCH 2/4] ---

On Thu, 07 May 2026, Sachin Sant wrote:
> syscalls/io_uring: Add test for partial vector operations

Nit: the subject prefix "syscalls/io_uring:" should be "io_uring:" to
match the rest of the series.

--- [PATCH 4/4] ---

On Thu, 07 May 2026, Sachin Sant wrote:
> io_uring: remove unused io_uring_init_buffer_pattern()

> The io_uring04 test merged the functionality of
> io_uring_init_buffer_pattern() into the unified function
> io_uring_init_iovec_buffers().

The function name is wrong here. The replacement function introduced in
this series is io_uring_init_iovec_pattern(), not
io_uring_init_iovec_buffers() (which does not exist).

--- [PATCH 1/4, 2/4, 3/4] ---

On Thu, 07 May 2026, Sachin Sant wrote:
> +static void run(void)
> +{
> +	int fd = -1;
> +	...
> +	fd = SAFE_OPEN(TEST_FILE, O_RDWR | O_CREAT | O_TRUNC, 0644);

fd is a local variable; if tst_brk() fires between SAFE_OPEN and
SAFE_CLOSE (e.g. inside io_uring_do_vec_io_op or SAFE_FSYNC),
cleanup() has no reference to it and cannot close it. Declare fd as
static int fd = -1 at file scope, reset it at the top of run(), and
close it in cleanup() if >= 0. Applies to all three new test files.

> +/*\
> + *
> + * Test partial vector operations with IORING_OP_READV and IORING_OP_WRITEV.

(io_uring05.c, io_uring06.c) Extra blank line after /*\; the description
must start on the very next line. See io_uring04.c for the correct style.

---
Note:

Our agent completed the review of the patch. The full review can be
found at: https://github.com/linux-test-project/ltp-agent/actions/runs/25458989491

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp