Linux Test Project
 help / color / mirror / Atom feed
From: linuxtestproject.agent@gmail.com
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] lib: safe_file_ops: Add SAFE_FILE_READ_STR()
Date: Thu,  7 May 2026 08:26:45 +0000	[thread overview]
Message-ID: <20260507082645.3925-1-linuxtestproject.agent@gmail.com> (raw)
In-Reply-To: <20260507075006.8690-2-chrubis@suse.cz>

Hi Cyril,

--- [PATCH 1/2] ---

On Thu, 7 May 2026, Cyril Hrubis wrote:
> lib: safe_file_ops: Add SAFE_FILE_READ_STR()

> +	if (!fgets(buf, buf_size, f))
> +		buf[0] = 0;
> +
> +	size_t len = strlen(buf);

Move `size_t len` to the top of the function alongside `FILE *f`; mixed
declarations after executable statements violate kernel coding style.

--- [PATCH 2/2] ---

On Thu, 7 May 2026, Cyril Hrubis wrote:
> syscalls: newuname01: Fix fail on empty domainname

> Fixes: https://github.com/linux-test-project/ltp/issues/1304

`Fixes:` must reference a git commit hash in the form
`Fixes: <hash> ("<subject>")`. Use `Closes:` to reference GitHub issues.

---
Note:

Our agent completed the review of the patch.

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2026-05-07  8:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-07  7:50 [LTP] [PATCH v2 0/2] Fix proc parsing in newuname01 Cyril Hrubis
2026-05-07  7:50 ` [LTP] [PATCH v2 1/2] lib: safe_file_ops: Add SAFE_FILE_READ_STR() Cyril Hrubis
2026-05-07  8:26   ` linuxtestproject.agent [this message]
2026-05-07  8:29     ` [LTP] " Andrea Cervesato via ltp
2026-05-07  8:29   ` [LTP] [PATCH v2 1/2] " Andrea Cervesato via ltp
2026-05-07  7:50 ` [LTP] [PATCH v2 2/2] syscalls: newuname01: Fix fail on empty domainname Cyril Hrubis
2026-05-07  8:29   ` Andrea Cervesato via ltp
2026-05-07  8:34 ` [LTP] [PATCH v2 0/2] Fix proc parsing in newuname01 Andrea Cervesato via ltp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260507082645.3925-1-linuxtestproject.agent@gmail.com \
    --to=linuxtestproject.agent@gmail.com \
    --cc=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox