From: Petr Vorel <pvorel@suse.cz>
To: Wei Gao <wegao@suse.com>
Cc: Jan Kara <jack@suse.cz>,
kernel test robot <oliver.sang@intel.com>,
ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v8] fanotify22.c: handle multiple asynchronous error events
Date: Wed, 13 May 2026 12:33:57 +0200 [thread overview]
Message-ID: <20260513103357.GA318856@pevik> (raw)
In-Reply-To: <20260507025345.6722-1-wegao@suse.com>
Hi all,
...
> if (memcmp(&fid->fsid, &ex->fid->fsid, sizeof(fid->fsid))) {
> - tst_res(TFAIL, "%s: Received bad FSID type (%x...!=%x...)",
> - ex->name, FSID_VAL_MEMBER(fid->fsid, 0),
> + tst_res(TFAIL, "Received bad FSID type (%x...!=%x...)",
> + FSID_VAL_MEMBER(fid->fsid, 0),
> ex->fid->fsid.val[0]);
I dared to factor out this unrelated change to a separated commit and merge the
patchset.
Removing ex->name which is ~ 50% of changes is completely unrelated.
When Andrea suggested it [1] it was for a new additions. Although this this
change is not a complicated, fanotify tests are quite complex, that's why it's
better to separate non-related change.
Thanks Jan for helping with the review.
Kind regards,
Petr
[1] https://lore.kernel.org/ltp/69c648d0.050a0220.2ca52b.c494@mx.google.com/
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-05-13 10:34 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-29 1:27 [LTP] [PATCH v1] io_submit04: Add test case for RWF_NOWAIT flag Wei Gao via ltp
2024-02-06 15:59 ` Petr Vorel
2025-10-22 2:05 ` [LTP] [PATCH v2] " Wei Gao via ltp
2025-12-18 13:21 ` Andrea Cervesato via ltp
2025-12-24 8:49 ` [LTP] [PATCH v3] " Wei Gao via ltp
2026-01-05 12:53 ` Andrea Cervesato via ltp
2026-01-06 6:26 ` Wei Gao via ltp
2026-01-06 8:39 ` Andrea Cervesato via ltp
2026-01-06 8:39 ` Petr Vorel
2026-01-07 8:53 ` Jan Stancek via ltp
2026-01-07 6:10 ` [LTP] [PATCH v4] " Wei Gao via ltp
2026-02-18 12:21 ` Andrea Cervesato via ltp
2026-03-05 4:41 ` Wei Gao via ltp
2026-03-17 7:43 ` [LTP] [PATCH v5] " Wei Gao via ltp
2026-03-17 9:54 ` Andrea Cervesato via ltp
2026-03-17 11:46 ` [LTP] [PATCH v6] " Wei Gao via ltp
2026-03-20 12:54 ` Andrea Cervesato via ltp
2026-03-27 18:17 ` Petr Vorel
2026-03-30 8:08 ` Wei Gao via ltp
2026-04-04 1:00 ` Wei Gao via ltp
2026-03-31 11:18 ` [LTP] [PATCH v7] fanotify22.c: handle multiple asynchronous error events Wei Gao via ltp
2026-04-29 14:51 ` [LTP] " linuxtestproject.agent
2026-05-07 2:58 ` Wei Gao via ltp
2026-05-07 2:53 ` [LTP] [PATCH v8] " Wei Gao via ltp
2026-05-07 6:18 ` [LTP] " linuxtestproject.agent
2026-05-07 7:37 ` [LTP] [PATCH v8] " Andrea Cervesato via ltp
2026-05-11 11:30 ` Jan Kara
2026-05-13 10:33 ` Petr Vorel [this message]
2026-04-04 1:13 ` [LTP] [PATCH v7] io_submit04: Add test case for RWF_NOWAIT flag Wei Gao via ltp
2026-04-08 15:11 ` Cyril Hrubis
2026-04-09 2:26 ` Wei Gao via ltp
2026-04-09 8:03 ` Cyril Hrubis
2026-04-09 13:45 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260513103357.GA318856@pevik \
--to=pvorel@suse.cz \
--cc=jack@suse.cz \
--cc=ltp@lists.linux.it \
--cc=oliver.sang@intel.com \
--cc=wegao@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox