Linux Test Project
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: linuxtestproject.agent@gmail.com
Cc: ltp@lists.linux.it
Subject: Re: [LTP] thermal: add new test group
Date: Fri, 15 May 2026 16:42:42 +0200	[thread overview]
Message-ID: <20260515144242.GB40164@pevik> (raw)
In-Reply-To: <20260514141912.4030-1-linuxtestproject.agent@gmail.com>

Hi all,

actually v20 is better than this v21 => setting it changes requested.
I'd prefer to merge v20.

> Hi Piotr,

> On Thu, 14 May 2026 15:34:47 +0200, Piotr Kubaj wrote:
> > thermal: add new test group

> > +	while (sleep_time > 0) {
> > +		...
> > +		if (temp > temp_high)
> > +			break;
> > +		sleep(sleep_time--);

> G2: sleep() used for synchronization. This is not a timer API test so
> the G2 exemption does not apply. Consider polling with
> tst_timer_expired_ms() or discuss with maintainers if a thermal-specific
> exception is appropriate.

> > +			tst_res(TINFO, "Cooling down for %d seconds", COOLDOWN);
> > +			sleep(COOLDOWN);

> G2: Same issue — sleep() used as a synchronization barrier for CPU
> cooldown between zone tests. If a non-sleep alternative is genuinely
> infeasible for thermal testing, this needs explicit justification in the
> commit message.

Yes, cooldown could have been mentioned in the commit message, I'll add it for
v20.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2026-05-15 14:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-14 13:34 [LTP] [PATCH v21] thermal: add new test group Piotr Kubaj
2026-05-14 14:19 ` [LTP] " linuxtestproject.agent
2026-05-15 14:42   ` Petr Vorel [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-05-14  9:36 [LTP] [PATCH v20] " Piotr Kubaj
2026-05-14 12:00 ` [LTP] " linuxtestproject.agent
2026-05-15 14:39   ` Petr Vorel
2026-05-06 11:24 [LTP] [PATCH v19] " Piotr Kubaj
2026-05-06 14:16 ` [LTP] " linuxtestproject.agent
2026-05-06 14:23   ` Andrea Cervesato via ltp
2026-04-30  8:42 [LTP] [PATCH v18] " Piotr Kubaj
2026-04-30  9:18 ` [LTP] " linuxtestproject.agent
2026-04-30 11:28   ` Kubaj, Piotr
2026-04-28 12:46 [LTP] [PATCH v17] " Piotr Kubaj
2026-04-28 14:41 ` [LTP] " linuxtestproject.agent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260515144242.GB40164@pevik \
    --to=pvorel@suse.cz \
    --cc=linuxtestproject.agent@gmail.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox