From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 1/2] safe_macros: Add SAFE_READ_ANY_EAGAIN
Date: Tue, 26 May 2026 16:15:45 +0200 [thread overview]
Message-ID: <20260526141545.GA176931@pevik> (raw)
In-Reply-To: <ahWn6zko0ktmS15V@yuki.lan>
> Hi!
> > ...
> > > +/* supported values for safe_read() len_strict parameter */
> > Could we have kerneldoc (ok to fix before merge).
> > /**
> > * enum safe_read_opts - supported values for safe_read() len_strict parameter */
> > *
> > * @SAFE_READ_ANY: no length strictness, short reads are ok.
> > * @SAFE_READ_ALL: strict length, short reads trigger :c:enum:`TBROK <tst_res_flags>`.
> > * @SAFE_READ_ANY_EAGAIN: converts EAGAIN to read that returns 0.
> > */
> > Otherwise LGTM, thanks for spotting the error.
> I would avoid that for now, since we are likely going to change the API
> after the release. Is that okay?
Sure, I'm sorry I overlooked expected API change.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-05-26 14:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 8:34 [LTP] [PATCH 0/2] Fix inotify{07,08} TBROK where it should TFAIL Cyril Hrubis
2026-05-26 8:34 ` [LTP] [PATCH v2 1/2] safe_macros: Add SAFE_READ_ANY_EAGAIN Cyril Hrubis
2026-05-26 11:56 ` Avinesh Kumar via ltp
2026-05-26 13:39 ` Petr Vorel
2026-05-26 14:02 ` Cyril Hrubis
2026-05-26 14:15 ` Petr Vorel [this message]
2026-05-26 8:34 ` [LTP] [PATCH v2 2/2] syscalls/inotify{07, 08}: Fix TBROK on older kernels Cyril Hrubis
2026-05-26 8:44 ` Martin Doucha
2026-05-26 13:45 ` Petr Vorel
2026-05-26 13:59 ` Cyril Hrubis
2026-05-26 14:16 ` Petr Vorel
2026-05-26 15:03 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260526141545.GA176931@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox