Re: [LTP] [PATCH v2 2/2] fanotify13: fix test failure when running iterations

[Petr Vorel <pvorel@suse.cz>]

Hi all,

it also fails on openSUSE Leap 42.2 due missing renameat2 (the same fix as for
musl described in previous email).

> +	if (tst_variant && (tc->mask & FAN_DELETE_SELF) &&
> +	    (!ovl_bind_mounted || rename_exchange_unsupported)) {
> +		/* The eviction of base fs inodes is defered due to overlay held reference */

While we are at it, we should fix old typo:
Typo: "defered" → "deferred".

Kind regards,
Petr

> +		tst_res(TCONF, "overlayfs base fs cannot be watched for delete self events");
> +		return;
> +	}
> +
>  	if (filesystem_mark_unsupported && mark->flag != FAN_MARK_INODE) {
>  		FANOTIFY_MARK_FLAGS_ERR_MSG(mark, filesystem_mark_unsupported);
>  		return;
> @@ -212,11 +220,6 @@ static void do_test(unsigned int number)
>  			tst_res(TCONF, "overlayfs base fs cannot be watched with mount mark");
>  			goto out;
>  		}
> -		if (tc->mask & FAN_DELETE_SELF) {
> -			/* The eviction of base fs inodes is defered due to overlay held reference */
> -			tst_res(TCONF, "overlayfs base fs cannot be watched for delete self events");
> -			goto out;
> -		}

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp