Re: [LTP] lapi/xfrm.h: Include system XFRM header

[linuxtestproject.agent@gmail.com]

Hi Martin,

On Mon, 1 Jun 2026 15:20:46 +0200, Martin Doucha wrote:
> lapi/xfrm.h: Include system XFRM header

--- [PATCH 2/6] ---

> xfrm01: Use NETDEV_SET_STATE() to activate loopback
>
> Signed-off-by: Martin Doucha <mdoucha@suse.cz>

The body is missing. The subject states what changed, but not why.
What is the motivation for switching from tst_cmd() to
NETDEV_SET_STATE() here? Patches 3-6 remove the "ip" command
dependency entirely, so presumably this is a step toward that goal,
but this commit stands alone and should explain the reason.

This patch needs revision.

Pre-existing issues noticed in the surrounding code (not introduced
by this patch):

- testcases/network/sockets/xfrm02.c in try_corrupt() -- usleep(30000)
  used to wait for the espintcp strparser to process buffered data.
  Ground Rule 2 prohibits sleep-based synchronization. An
  exponential-backoff polling loop on the processed data would be
  more robust under load.

- testcases/network/sockets/xfrm03.c in try_corrupt() -- same
  usleep(30000) for the same reason.

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp