Re: [LTP] cfs-scheduler: Fixed "make check" errors and warnings in hackbench.c

[linuxtestproject.agent@gmail.com]

Hi Samir,

Some issues need to be addressed before this can be merged.

On Tue, 02 Jun 2026 11:56:56 +0200, Samir <samir@linux.ibm.com> wrote:
> cfs-scheduler: Fixed "make check" errors and warnings in hackbench.c

[COMMIT MESSAGE]

1. Subject line uses past tense. LTP (like the Linux kernel) uses
   imperative mood in commit subjects:

     cfs-scheduler: Fix 'make check' errors and warnings in hackbench.c

   Also, prefer single quotes over double quotes in subjects.

2. The Signed-off-by line contains only a first name. The DCO requires
   a real full name (first and last). Please use your full name, e.g.:

     Signed-off-by: Samir Lastname <samir@linux.ibm.com>

3. The version-tracking block does not belong in the commit message body.
   Remove it before merging:

     Patch v1: https://lore.kernel.org/ltp/20260407062336.127454-1-samir@linux.ibm.com/
     Patch v2: https://lore.kernel.org/ltp/20260412122842.1074017-1-samir@linux.ibm.com/

     Addressed review comments from patch v2 -> patch v3:
     - Add SPDX-License-Identifier header as requested by Andrea Cervesato.

   This is patch-submission metadata for the cover letter / lore thread,
   not part of the permanent history.

4. The bullet-list body ("hackbench.c: - Add SPDX-License-Identifier …")
   describes individual line changes that are self-evident from the diff.
   Replace it with one or two sentences explaining *why* the changes were
   made, e.g.:

     Fix all "make check" warnings in hackbench.c to comply with the LTP
     coding style guidelines.

[CODE]

> -/* Copyright Rusty Russell,                                                   */
> -/* Copyright Pierre Peiffer                                                   */
> -/* Copyright Zhang, Yanmin,                                                   */
> -/* Copyright Ingo Molnar,                                                     */
> -/* Copyright Arjan van de Ven,                                                */
> +/* Authors: Rusty Russell <rusty@rustcorp.com.au>                             */
> +/*          Pierre Peiffer <pierre.peiffer@bull.net>                          */
> +/*          Ingo Molnar <mingo@elte.hu>                                       */
> +/*          Arjan van de Ven <arjan@infradead.org>                            */
> +/*          Zhang, Yanmin <yanmin_zhang@linux.intel.com>                    */

5. The original file listed these five contributors as *copyright holders*
   ("Copyright Rusty Russell", etc.). The patch silently demotes them to
   mere "Authors" entries, stripping the copyright designation entirely.
   Copyright notices must be preserved. Either retain them as copyright
   lines (adding emails where known) or obtain explicit permission from
   each holder to remove the copyright claim.

   For example:
     /* Copyright Rusty Russell <rusty@rustcorp.com.au>                       */
     /* Copyright Pierre Peiffer <pierre.peiffer@bull.net>                    */
     ...

6. The Zhang, Yanmin line in the Authors block has fewer trailing spaces
   than the other lines, breaking the column alignment:

     /*          Zhang, Yanmin <yanmin_zhang@linux.intel.com>                    */
                                                             ^-- only 20 spaces

   All other entries end with 26 spaces before "*/". Pad to match.

> -	for (j = 0; j < num_fds; j++) {
> -		SAFE_FREE(rev_ctx_tab[i * num_fds + j])
> -	}
> +	for (j = 0; j < num_fds; j++)
> +		SAFE_FREE(rev_ctx_tab[i * num_fds + j])

7. Every other call to SAFE_FREE in the file is terminated with a
   semicolon (e.g. "SAFE_FREE(snd_ctx_tab[i]);"). Although the macro
   expands to a compound statement so the semicolon is not strictly
   required, omitting it here creates an inconsistency. Add the semicolon:

     SAFE_FREE(rev_ctx_tab[i * num_fds + j]);

Verdict: Needs revision

Thanks,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp