Re: [LTP] syscalls: skip ntfs3 in ioctl_fiemap01 and mount03

[linuxtestproject.agent@gmail.com]

Hi XiaoLei Wu,

Thank you for the patch. Review below.

> syscalls: skip ntfs3 in ioctl_fiemap01 and mount03
>
> Since commit 7dc8e9a515ce ("lib: Treat kernel ntfs3 as a separate FS"),
> tests with all_filesystems=1 run on ntfs3 independently.
>
> ioctl_fiemap01 and mount03 already skip ntfs, but still run on ntfs3.
> ioctl_fiemap01 fails because the returned FIEMAP extents do not match
> the layout expected by the test. mount03 fails because directory
> timestamps are not updated as expected under strictatime. Add ntfs3 to
> their skip lists, matching the existing ntfs skips.
>
> Signed-off-by: XiaoLei Wu <wxl18715129466@gmail.com>

Commit message looks good. The "Since commit ..." reference clearly
explains the motivation. Optionally, a formal:

  Fixes: 7dc8e9a515ce ("lib: Treat kernel ntfs3 as a separate FS")

trailer would aid automated tracking, though the inline reference is
acceptable per LTP convention.

> diff --git a/testcases/kernel/syscalls/ioctl/ioctl_fiemap01.c b/testcases/kernel/syscalls/ioctl/ioctl_fiemap01.c
> @@ -119,7 +119,7 @@ static struct tst_test test = {
>  	.mntpoint = MNTPOINT,
>  	.all_filesystems = 1,
>  	.skip_filesystems = (const char *const[]) {
> -		"exfat", "vfat", "fuse", "ntfs", "tmpfs", NULL
> +		"exfat", "vfat", "fuse", "ntfs", "ntfs3", "tmpfs", NULL
>  	},

Correct. ntfs3 is placed between the existing ntfs and tmpfs entries,
and matches the rationale: FIEMAP extent layout on ntfs3 does not match
the three-extent layout the test builds by writing at block offsets 0,
2, and 4.

> diff --git a/testcases/kernel/syscalls/mount/mount03.c b/testcases/kernel/syscalls/mount/mount03.c
> @@ -256,6 +256,7 @@ static struct tst_test test = {
>  		"exfat",
>  		"vfat",
>  		"ntfs",
> +		"ntfs3",
>  		NULL
>  	},

Correct. ntfs3 is inserted immediately after the existing ntfs entry.
The commit message correctly identifies that test_strictatime() —
which calls test_file_dir_noatime(1, 1) expecting both file and
directory access times to be updated under MS_STRICTATIME — fails on
ntfs3 because the kernel ntfs3 driver does not update directory
timestamps as the Linux VFS expects.

Both tests are listed in runtest/syscalls. No Makefile changes are
needed since no new files are added.

--- Pre-existing issues (informational, do not affect verdict) ---

ioctl_fiemap01.c: verify_ioctl() allocates fiemap and buf via
SAFE_MALLOC, and opens fd via SAFE_OPEN, but only frees/closes them
at the function's end. If any SAFE_* macro in the middle aborts via
tst_brk(), the allocations are leaked for the duration of the
all_filesystems loop iteration. In practice this is harmless because
the mounts are torn down between iterations, but a .cleanup callback
closing fd would be cleaner. This is pre-existing and not introduced by
this patch.

--- End pre-existing issues ---

Verdict: Reviewed

Reviewed-by: LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp