From: linuxtestproject.agent@gmail.com
To: Samir <samir@linux.ibm.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] cfs-scheduler: Fixed "make check" warning in cfs_bandwidth01.c
Date: Tue, 2 Jun 2026 11:24:00 +0000 [thread overview]
Message-ID: <20260602112400.4056-1-linuxtestproject.agent@gmail.com> (raw)
In-Reply-To: <20260602100512.404810-1-samir@linux.ibm.com>
Hi Samir,
On Tue Jun 2 12:05:12 2026 +0200, Samir wrote:
> cfs-scheduler: Fixed "make check" warning in cfs_bandwidth01.c
> -static int may_have_waiters = 0;
> +static int may_have_waiters;
All good. Reviewed.
Pre-existing issues noticed in the surrounding code (not introduced
by this patch):
- cfs_bandwidth01.c in do_test() -- sleep(1) and sleep(2) are used
for process synchronization (waiting for workers to start and for
throttling to take effect). Is there a checkpoint-based or
polling-based approach that could replace these to avoid flakiness
under load? The checkpoint mechanism is already used elsewhere in
this test.
---
Note:
The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-06-02 11:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-02 10:05 [LTP] [PATCH v3] cfs-scheduler: Fixed "make check" warning in cfs_bandwidth01.c Samir
2026-06-02 11:24 ` linuxtestproject.agent [this message]
2026-06-12 8:28 ` Andrea Cervesato via ltp
2026-06-12 8:32 ` Andrea Cervesato via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260602112400.4056-1-linuxtestproject.agent@gmail.com \
--to=linuxtestproject.agent@gmail.com \
--cc=ltp@lists.linux.it \
--cc=samir@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox