Re: [LTP] fw_load: Modernize ltp_fw_load kernel module

[linuxtestproject.agent@gmail.com]

Hi Andrea,

On Wed, 10 Jun 2026, Andrea Cervesato wrote:
> fw_load: Modernize ltp_fw_load kernel module

--- [PATCH 1/3] ---

> diff --git a/testcases/kernel/firmware/fw_load_kernel/Makefile
> b/testcases/kernel/firmware/fw_load_kernel/Makefile
> --- a/testcases/kernel/firmware/fw_load_kernel/Makefile
> +++ b/testcases/kernel/firmware/fw_load_kernel/Makefile
>  # Copyright (c) 2013 Oracle and/or its affiliates. All Rights Reserved.
> +# Copyright (c) Linux Test Project, 2026
> +# SPDX-License-Identifier: GPL-2.0-or-later

The SPDX tag must be the first line of the Makefile, before the
Copyright lines.

--- [PATCH 2/3] ---

> diff --git a/testcases/kernel/firmware/fw_load/fw_load.h
> b/testcases/kernel/firmware/fw_load/fw_load.h
> +#ifndef FW_LOAD_H
> +
> +#define MNAME_KO "ltp_fw_load.ko"

Missing `#define FW_LOAD_H` after the `#ifndef`. Without it the
include guard is non-functional.

Verdict: Needs revision

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp