Re: [LTP] metadata: add tests grouping support

[linuxtestproject.agent@gmail.com]

Hi Andrea,

On Thu, 18 Jun 2026 16:10:26 +0200, Andrea Cervesato wrote:
> metadata: add tests grouping support

--- [PATCH 1/2] ---

> +#define GROUPS_TAG "groups"

> +static int parse_groups(struct data_node *groups, char *line)
> +{
> +	s = (char *)eat_asterisk_space(line);
> +	if (strncmp(s, GROUPS_TAG, sizeof(GROUPS_TAG) - 1))
> +		return 0;

After eat_asterisk_space() strips the leading " * " from a doc
comment line, the string still begins with '@' (e.g. "@groups stress
regression"). The strncmp therefore compares "@group" against
"groups", which never matches.

Should GROUPS_TAG be "@groups" instead?

Verdict - Needs revision

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp