From: linuxtestproject.agent@gmail.com
To: Andrea Cervesato <andrea.cervesato@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] metadata: add linter for JSON file
Date: Wed, 24 Jun 2026 16:24:11 +0000 [thread overview]
Message-ID: <20260624162411.3943-1-linuxtestproject.agent@gmail.com> (raw)
In-Reply-To: <20260624-metadata_linter-v1-1-3d9506169aad@suse.com>
Hi Andrea,
On Wed, 24 Jun 2026 16:27:21 +0200, Andrea Cervesato wrote:
> metadata: add linter for JSON file
> + parser.add_argument(
> + "--check-cve-online",
> + action="store_true",
> + help="verify CVE existence against the online CVE database",
> + )
> + args = parser.parse_args()
> + errors: List[str] = lint_tests(tests, args.check_cve_exists)
argparse stores --check-cve-online as check_cve_online, but the code
reads check_cve_exists. This raises AttributeError every time main()
runs, even when the flag is not passed (the attribute simply does not
exist on the Namespace object).
Should this be args.check_cve_online?
Verdict - Needs revision
---
Note:
The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-06-24 16:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-24 14:27 [LTP] [PATCH] metadata: add linter for JSON file Andrea Cervesato
2026-06-24 16:24 ` linuxtestproject.agent [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-06-25 13:59 [LTP] [PATCH v3] " Andrea Cervesato
2026-06-25 15:43 ` [LTP] " linuxtestproject.agent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260624162411.3943-1-linuxtestproject.agent@gmail.com \
--to=linuxtestproject.agent@gmail.com \
--cc=andrea.cervesato@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox