From: Petr Vorel <pvorel@suse.cz>
To: Michael Menasherov <mmenashe@redhat.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v16 2/2] futex_cmp_requeue03: Add EFAULT error coverage test
Date: Fri, 3 Jul 2026 15:19:11 +0200 [thread overview]
Message-ID: <20260703131911.GA407003@pevik> (raw)
In-Reply-To: <20260621150951.66407-3-mmenashe@redhat.com>
Hi Michael,
...
> +static struct testcase {
> + const char *desc;
> + futex_t **uaddr;
> + futex_t **uaddr2;
> + int exp_errno;
> +} testcases[] = {
> + {
> + .desc = "uaddr unmapped",
> + .uaddr = &unmapped_addr,
> + .uaddr2 = &futex_ptr,
> + .exp_errno = EFAULT,
> + },
> + {
> + .desc = "uaddr2 unmapped",
> + .uaddr = &futex_ptr,
> + .uaddr2 = &unmapped_addr,
> + .exp_errno = EFAULT,
> + },
> + {
> + .desc = "uaddr PROT_NONE",
> + .uaddr = &prot_none_addr,
> + .uaddr2 = &futex_ptr,
> + .exp_errno = EFAULT,
> + },
> + {
> + .desc = "uaddr2 PROT_NONE",
> + .uaddr = &futex_ptr,
> + .uaddr2 = &prot_none_addr,
> + .exp_errno = EFAULT,
> + },
> +};
nit: also here I'd use EFAULT directly in TST_EXP_FAIL(), but that's a minor
detail.
The rest LGTM.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2026-07-03 13:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-21 15:09 [LTP] [PATCH v16 0/2] futex: Add EFAULT coverage for wake and cmp_requeue Michael Menasherov via ltp
2026-06-21 15:09 ` [LTP] [PATCH v16 1/2] futex_wake05: Add EFAULT error coverage test Michael Menasherov via ltp
2026-06-22 9:44 ` [LTP] " linuxtestproject.agent
2026-06-23 13:34 ` [LTP] [PATCH v16 1/2] " Andrea Cervesato via ltp
2026-07-03 8:32 ` Petr Vorel
2026-06-21 15:09 ` [LTP] [PATCH v16 2/2] futex_cmp_requeue03: " Michael Menasherov via ltp
2026-06-23 13:35 ` Andrea Cervesato via ltp
2026-07-03 13:19 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260703131911.GA407003@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=mmenashe@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox