Re: [LTP] connect03: New test case for EPROTOTYPE and EACCES errors

[linuxtestproject.agent@gmail.com]

Hi Wei,

On Mon, 06 Jul 2026 06:02:34 +0000, Wei Gao <wegao@suse.com> wrote:
> connect03: New test case for EPROTOTYPE and EACCES errors

> Add a new connect03 test case targeting AF_UNIX-specific connect(2)
> error paths, specifically EPROTOTYPE and EACCES.
>
> - EPROTOTYPE is verified by attempting to connect a UNIX domain SOCK_DGRAM
>   socket to a SOCK_STREAM listening server.
> - EACCES is verified by modifying permissions on the socket file to 0700,
>   spawning a child process, dropping privileges to the unprivileged "nobody"
>   user, and attempting to connect.

The body describes the mechanics of both test cases, but does not state
why this new test is needed -- what gap does it fill? Does connect01 or
connect02 already cover AF_UNIX-specific error paths?

Rule 2 in the LTP commit-message guidelines requires the body to state
the motivation or problem being solved, not just what was changed.
A sentence like "connect01/02 only cover generic socket error paths and
do not test AF_UNIX-specific errors" would satisfy this.

Verdict - Needs revision

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp