From: linuxtestproject.agent@gmail.com
To: Andrea Cervesato <andrea.cervesato@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] landlock: fix make check warnings/errors
Date: Mon, 6 Jul 2026 20:03:06 +0000 [thread overview]
Message-ID: <20260706200306.3982-1-linuxtestproject.agent@gmail.com> (raw)
In-Reply-To: <20260706-fix_make_check_landlock-v2-1-4949150d17e4@suse.com>
Hi Andrea,
On Mon, 7 Jul 2026, Andrea Cervesato wrote:
> landlock: fix make check warnings/errors
> - if (errno == EOPNOTSUPP) {
> - tst_brk(TCONF, "Landlock is currently disabled. "
> - "Please enable it either via CONFIG_LSM or "
> - "'lsm' kernel parameter.");
> - }
> + if (errno == EOPNOTSUPP)
> + tst_brk(TCONF, "Landlock is currently disabled. Please enable it either via CONFIG_LSM or 'lsm' kernel parameter.");
The new line in landlock_common.h is ~132 characters long. The
original multi-line string had an alignment warning, but this hunk
trades it for a line-over-80-characters warning, which checkpatch
will still flag.
Could the string be re-wrapped to satisfy the line-length limit,
for example:
if (errno == EOPNOTSUPP)
tst_brk(TCONF,
"Landlock is currently disabled. Please "
"enable it either via CONFIG_LSM or "
"'lsm' kernel parameter.");
Verdict - Needs revision
---
Note:
The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-07-06 20:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-06 19:17 [LTP] [PATCH v2] landlock: fix make check warnings/errors Andrea Cervesato
2026-07-06 20:03 ` linuxtestproject.agent [this message]
2026-07-13 11:36 ` Petr Vorel
2026-07-13 11:55 ` Andrea Cervesato via ltp
2026-07-14 7:31 ` Andrea Cervesato via ltp
2026-07-14 7:37 ` Andrea Cervesato via ltp
-- strict thread matches above, loose matches on Subject: below --
2026-07-06 10:32 [LTP] [PATCH] " Andrea Cervesato
2026-07-06 14:38 ` [LTP] " linuxtestproject.agent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260706200306.3982-1-linuxtestproject.agent@gmail.com \
--to=linuxtestproject.agent@gmail.com \
--cc=andrea.cervesato@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox